Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918343002: Make views_mus_unittests use a static manifest (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make views_mus_unittests use a static manifest Extracted from https://codereview.chromium.org/1910043002/ to help identify an issue. TBR=sky@chromium.org BUG= Committed: https://crrev.com/21397d6e816b360e5a00d55b402c8cc30cf5c0a7 Cr-Commit-Position: refs/heads/master@{#389828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M ui/views/mus/BUILD.gn View 3 chunks +8 lines, -0 lines 0 comments Download
M ui/views/mus/platform_test_helper_mus.cc View 2 chunks +2 lines, -11 lines 0 comments Download
A ui/views/mus/unittests_manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918343002/1
4 years, 8 months ago (2016-04-26 17:57:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 18:56:02 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 18:57:43 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/21397d6e816b360e5a00d55b402c8cc30cf5c0a7
Cr-Commit-Position: refs/heads/master@{#389828}

Powered by Google App Engine
This is Rietveld 408576698