[DevTools] Simplified DebuggerScript._buildScopeObject

third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 377 matching lines @@
         return numbers;
 
     for (var i = 0; i < breakpoints.length; i++) {
         var breakpoint = breakpoints[i];
         var scriptBreakPoint = breakpoint.script_break_point();
         numbers.push(scriptBreakPoint ? scriptBreakPoint.number() : breakpoint.number());
     }
     return numbers;
 }
 
-// NOTE: This function is performance critical, as it can be run on every
-// statement that generates an async event (like addEventListener) to support
-// asynchronous call stacks. Thus, when possible, initialize the data lazily.
 /**
  * @param {!FrameMirror} frameMirror
  * @return {!JavaScriptCallFrame}
  */
 DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror)
 {
     // Stuff that can not be initialized lazily (i.e. valid while paused with a valid break_id).
     // The frameMirror and scopeMirror can be accessed only while paused on the debugger.
     var frameDetails = frameMirror.details();
 
@@ skipping 248 matching lines @@
     };
 }
 
 /**
  * @param {number} scopeType
  * @param {!Object} scopeObject
  * @return {!Object|undefined}
  */
 DebuggerScript._buildScopeObject = function(scopeType, scopeObject)
 {
-    var result;
-    switch (scopeType) {
-    case ScopeType.Local:
-    case ScopeType.Closure:
-    case ScopeType.Catch:
-    case ScopeType.Block:
-    case ScopeType.Script:
-        // For transient objects we create a "persistent" copy that contains
-        // the same properties.
-        // Reset scope object prototype to null so that the proto properties
-        // don't appear in the local scope section.
-        var properties = /** @type {!ObjectMirror} */(MakeMirror(scopeObject, true /* transient */)).properties();
-        // Almost always Script scope will be empty, so just filter out that noise.
-        // Also drop empty Block scopes, should we get any.
-        if (!properties.length && (scopeType === ScopeType.Script || scopeType === ScopeType.Block))
-            break;
-        result = { __proto__: null };
-        for (var j = 0; j < properties.length; j++) {
-            var name = properties[j].name();
-            if (name.length === 0 || name.charAt(0) === ".")
-                continue; // Skip internal variables like ".arguments" and variables with empty name
-            result[name] = properties[j].value_;
-        }
-        break;
-    case ScopeType.Global:
-    case ScopeType.With:
-        result = scopeObject;
-        break;
+    // Almost always Script scope will be empty, so just filter out that noise.
+    // Also drop empty Block scopes, should we get any.
+    if (scopeType === ScopeType.Script || scopeType === ScopeType.Block) {
+        if (Object.getOwnPropertyNames(scopeObject).length === 0)
+            return undefined;
     }
-    return result;
+    return scopeObject;
 }
 
 // We never resolve Mirror by its handle so to avoid memory leaks caused by Mirrors in the cache we disable it.
 ToggleMirrorCache(false);
 
 return DebuggerScript;
 })();