Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1918323002: [DevTools] Simplified DebuggerScript._buildScopeObject (Closed)

Created:
4 years, 8 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Simplified DebuggerScript._buildScopeObject - due to fact that V8 materializes stack variables we can just pass scopeObject, - removed obsolete comment about async scopes, - removed some types from debugger_script_externs.js - removed hack for filtering variables with empty name because it's fixed in V8.

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -63 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/DebuggerScript.js View 1 2 chunks +6 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/debugger_script_externs.js View 6 chunks +4 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
kozy
Description was changed from ========== [DevTools] Simplified DebuggerScript._buildScopeObject - since V8 materializes stack variables we ...
4 years, 8 months ago (2016-04-26 17:37:11 UTC) #1
kozy
Description was changed from ========== [DevTools] Simplified DebuggerScript._buildScopeObject - since V8 materializes stack variables we ...
4 years, 8 months ago (2016-04-26 17:37:37 UTC) #2
kozy
Patchset #2 (id:20001) has been deleted
4 years, 8 months ago (2016-04-26 20:45:10 UTC) #3
kozy
Description was changed from ========== [DevTools] Simplified DebuggerScript._buildScopeObject - due to fact that V8 materializes ...
4 years, 5 months ago (2016-07-11 18:26:36 UTC) #4
kozy
4 years, 5 months ago (2016-07-11 18:26:37 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698