Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1918303002: Renaming system.gyp:ssl to system.gyp:nss and removing unused BUILD.gn (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 7 months ago
CC:
chromium-reviews, Dirk Pranke, cbentzel+watch_chromium.org, tfarina, jam, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming system.gyp:ssl to system.gyp:nss and removing unused BUILD.gn BUG=604728 TBR=thakis@chromium.org, jbauman@chromium.org Committed: https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0 Cr-Commit-Position: refs/heads/master@{#390962}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -973 lines) Patch
M build/linux/system.gyp View 1 chunk +23 lines, -30 lines 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 1 1 chunk +1 line, -923 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/ownership.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/test_support_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M crypto/crypto.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M net/net.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/net_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
svaldez
4 years, 8 months ago (2016-04-26 17:01:22 UTC) #2
davidben
lgtm
4 years, 8 months ago (2016-04-26 17:13:43 UTC) #3
davidben
https://codereview.chromium.org/1918303002/diff/1/build/secondary/third_party/nss/BUILD.gn File build/secondary/third_party/nss/BUILD.gn (left): https://codereview.chromium.org/1918303002/diff/1/build/secondary/third_party/nss/BUILD.gn#oldcode22 build/secondary/third_party/nss/BUILD.gn:22: } else if (is_ios) { How much do you ...
4 years, 8 months ago (2016-04-26 17:14:11 UTC) #4
svaldez
Hi, This is renaming system.gyp:ssl to system.gyp:nss as part of the removal of using NSS ...
4 years, 8 months ago (2016-04-26 17:46:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918303002/1
4 years, 7 months ago (2016-04-27 15:42:33 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 18:03:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918303002/1
4 years, 7 months ago (2016-04-29 20:33:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175506)
4 years, 7 months ago (2016-04-29 20:50:11 UTC) #14
Alexander Alekseev
components/ownership.gypi lgtm
4 years, 7 months ago (2016-04-30 02:04:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918303002/1
4 years, 7 months ago (2016-05-02 15:07:53 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/28098) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-02 15:10:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918303002/20001
4 years, 7 months ago (2016-05-02 15:19:05 UTC) #23
Nico
lgtm
4 years, 7 months ago (2016-05-02 15:25:10 UTC) #24
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-02 16:21:26 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 16:23:36 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4fed186b2068597ec3f942af3c6fca8f29d70d0
Cr-Commit-Position: refs/heads/master@{#390962}

Powered by Google App Engine
This is Rietveld 408576698