Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1918253006: Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (Closed)

Created:
4 years, 7 months ago by reed1
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (patchset #2 id:20001 of https://codereview.chromium.org/1927583002/ ) Reason for revert: still blocking DEPS roll Original issue's description: > Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. > > The Release_Developer build type is now used to build Skia with > release level optimizations but still enable SK_DEBUG. This in turn > means that SkASSERTS and SkRTConf are available in this mode. > > Further we can then remove SK_DEVELOPER as a define as it is true > iff SK_DEBUG is true. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002 > DOCS_PREVIEW= https://skia.org/?cl=1927583002 > > Committed: https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db TBR=bungeman@gmail.com,bungeman@google.com,benjaminwagner@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/28d5bdd97ebbbdfff49d2e719b24a6343b0f0b48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M gyp/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkClipStack.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/gpu/GrConfig.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkRTConf.h View 1 chunk +1 line, -1 line 0 comments Download
M site/dev/runtime/index.md View 2 chunks +9 lines, -4 lines 0 comments Download
M src/core/SkClipStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkGraphics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkResourceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkStream.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrLayerCache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkResourceProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RuntimeConfigTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/pinspect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.
4 years, 7 months ago (2016-04-28 15:12:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918253006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918253006/1
4 years, 7 months ago (2016-04-28 15:12:44 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-04-28 15:12:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/28d5bdd97ebbbdfff49d2e719b24a6343b0f0b48

Powered by Google App Engine
This is Rietveld 408576698