Mark removable Drive caches for cryptohome.

components/drive/chromeos/file_cache.h

Index: components/drive/chromeos/file_cache.h
diff --git a/components/drive/chromeos/file_cache.h b/components/drive/chromeos/file_cache.h
index 23b104c9630a9b609e4957501ac8f8fe8823e414..2e31bf77325228cf48cefe6b00bb76b78c3b404d 100644
--- a/components/drive/chromeos/file_cache.h
+++ b/components/drive/chromeos/file_cache.h
@@ -53,6 +53,9 @@ class FreeDiskSpaceGetterInterface {
 // GetCacheFilePath() for example), should be run with |blocking_task_runner|.
 class FileCache {
  public:
+  // The file extended attribute assigned to Drive cache directory.
+  static const char kGCacheFilesAttribute[];
+
   // Enum defining type of file operation e.g. copy or move, etc.
   enum FileOperationType {
     FILE_OPERATION_MOVE = 0,
@@ -158,14 +161,6 @@ class FileCache {
       const ResourceMetadataStorage::RecoveredCacheInfoMap&
           recovered_cache_info);
 
-  // Migrates cache files from |from| directory to |to_files| directory with
-  // creating links in |to_links| directory if necessary. Returns true for
-  // success.
-  static bool MigrateCacheFiles(const base::FilePath& from,
-                                const base::FilePath& to_files,
-                                const base::FilePath& to_links,
-                                ResourceMetadataStorage* metadata_storage);
-
  private:
   friend class FileCacheTest;
 
@@ -191,6 +186,12 @@ class FileCache {
   // TODO(hashimoto): Remove this method at some point.
   bool RenameCacheFilesToNewFormat();
 
+  // Adds appropriate file attributes to the Drive cache directory and files in
+  // it for crbug.com/533750. Returns true on success.
+  // This also resolves inconsistency between cache files and metadata which can
+  // be produced when cryptohome removed cache files or on abrupt shutdown.
+  bool MigrateCacheFilesResolvingInconsistency();

[hashimoto, 2016/05/11 06:29:12]

"Migrate" sounds a bit misleading here as we are no longer moving files from one
directory another, and this functions is run on every boot.
I couldn't come up with a nice word to describe what this function is doing, but
it should be something like "fix metadata and file attributes".

[yawano, 2016/05/11 06:32:47]

How about "validate"?

[oka, 2016/05/11 09:35:04]

validate sounds like it has no side effect.
Named it FixMetadataAndFileAttributes.

+
   // This method must be called after writing to a cache file.
   // Used to implement OpenForWrite().
   void CloseForWrite(const std::string& id);