Try to fix damage from switching ClangToTAndroidASan to mb and gn.

Try to fix damage from switching ClangToTAndroidASan to mb and gn.

debug_bot_minimal_symbols implicitly enables goma (which doesn't work
with trunk clang), so don't use that.

android implicitly enables proprietary codecs; explicitly opt out from
that.

BUG=606780
R=dpranke@chromium.org

Committed: https://crrev.com/d8deaff6dd714d1446757e7b4038d544289f5230
Cr-Commit-Position: refs/heads/master@{#389793}

[Nico, 2016-04-26 15:02:48]

thakis@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-26 15:18:39]

lgtm for now; I think the bot should have the codecs to be consistent with the
others, but as an fyi bot it's not that important.

https://codereview.chromium.org/1918243002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1918243002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:900: 'shared', 'debug', 'minimal_symbols',
the config name now won't be following the normal convention (of the mixins
joined together).

following the convention will make the config too long (> 80 chars), so maybe
just call this something totally different, like 'android_clang_tot_asan' ?

[Nico, 2016-04-26 15:21:58]

I don't disagree that it'd be nice if the bot was consistent with others, but I
think others shouldn't build with internal codecs by default either.

https://codereview.chromium.org/1918243002/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/1918243002/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:900: 'shared', 'debug', 'minimal_symbols',
On 2016/04/26 15:18:39, Dirk Pranke wrote:
> the config name now won't be following the normal convention (of the mixins
> joined together).
> 
> following the convention will make the config too long (> 80 chars), so maybe
> just call this something totally different, like 'android_clang_tot_asan' ?

Done.

[Nico, 2016-04-26 15:22:01]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-04-26 15:22:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1918243002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-04-26 15:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918243002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918243002/20001

[Nico, 2016-04-26 15:47:35]

Description was changed from

==========
Try to fix damage from switching ClangToTAndroidASan to mb and gn.

debug_bot_minimal_symbols implicitly enables goma (which doesn't work
with trunk clang), so don't use that.

android implicitly enables proprietary codecs; explicitly opt out from
that.

BUG=606780
==========

to

==========
Try to fix damage from switching ClangToTAndroidASan to mb and gn.

debug_bot_minimal_symbols implicitly enables goma (which doesn't work
with trunk clang), so don't use that.

android implicitly enables proprietary codecs; explicitly opt out from
that.

BUG=606780
R=dpranke@chromium.org
==========

[Nico, 2016-04-26 15:47:36]

Committed patchset #2 (id:20001) to pending queue manually as
9521da44f6eb158198ae6badca238ebdc38c01b7 (presubmit successful).

[commit-bot: I haz the power, 2016-04-26 15:48:52]

Description was changed from

==========
Try to fix damage from switching ClangToTAndroidASan to mb and gn.

debug_bot_minimal_symbols implicitly enables goma (which doesn't work
with trunk clang), so don't use that.

android implicitly enables proprietary codecs; explicitly opt out from
that.

BUG=606780
R=dpranke@chromium.org
==========

to

==========
Try to fix damage from switching ClangToTAndroidASan to mb and gn.

debug_bot_minimal_symbols implicitly enables goma (which doesn't work
with trunk clang), so don't use that.

android implicitly enables proprietary codecs; explicitly opt out from
that.

BUG=606780
R=dpranke@chromium.org

Committed: https://crrev.com/d8deaff6dd714d1446757e7b4038d544289f5230
Cr-Commit-Position: refs/heads/master@{#389793}
==========

[commit-bot: I haz the power, 2016-04-26 15:48:53]

Patchset 2 (id:??) landed as
https://crrev.com/d8deaff6dd714d1446757e7b4038d544289f5230
Cr-Commit-Position: refs/heads/master@{#389793}