Added mark bit cell iterator.

Added mark bit cell iterator.

BUG=
R=mstarzinger@chromium.org, titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15691

[titzer, 2013-07-15 13:42:06]

LGTM with nits.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode1942
src/mark-compact.cc:1942: Address cell_base;
Can be in the loop, no? And also below.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.h#newcode965
src/mark-compact.h:965: Bitmap::CellAlignIndex(
Indentation

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.h#newcode975
src/mark-compact.h:975: ASSERT(cell_index_ ==
Can
fit
on
fewer
lines

[Michael Starzinger, 2013-07-15 14:01:46]

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode1943
src/mark-compact.cc:1943: MarkBit::CellType* cell;
nit: Lets move the declaration of the variables into the loop where they are
actually defined. More local, easier to read.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode1994
src/mark-compact.cc:1994: MarkBit::CellType* cell;
nit: Likewise.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode2971
src/mark-compact.cc:2971: MarkBit::CellType* cell;
nit: Likewise.

[Michael Starzinger, 2013-07-15 15:16:14]

LGTM (after Ben's and my comments are addressed).

[Hannes Payer (out of office), 2013-07-16 12:12:59]

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode1942
src/mark-compact.cc:1942: Address cell_base;
On 2013/07/15 13:42:06, titzer wrote:
> Can be in the loop, no? And also below.

Done.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode1943
src/mark-compact.cc:1943: MarkBit::CellType* cell;
On 2013/07/15 14:01:46, Michael Starzinger wrote:
> nit: Lets move the declaration of the variables into the loop where they are
> actually defined. More local, easier to read.

Done.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode1994
src/mark-compact.cc:1994: MarkBit::CellType* cell;
On 2013/07/15 14:01:46, Michael Starzinger wrote:
> nit: Likewise.

Done.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode2971
src/mark-compact.cc:2971: MarkBit::CellType* cell;
On 2013/07/15 14:01:46, Michael Starzinger wrote:
> nit: Likewise.

Done.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.h#newcode965
src/mark-compact.h:965: Bitmap::CellAlignIndex(
On 2013/07/15 13:42:06, titzer wrote:
> Indentation

Done.

https://codereview.chromium.org/19182002/diff/1/src/mark-compact.h#newcode975
src/mark-compact.h:975: ASSERT(cell_index_ ==
On 2013/07/15 13:42:06, titzer wrote:
> Can
> fit
> on
> fewer
> lines

Done.

[Hannes Payer (out of office), 2013-07-16 12:14:21]

Committed patchset #2 manually as r15691 (presubmit successful).