third_party/WebKit/Source/web/WebLocalFrameImpl.h - Issue 1918183004: Switch the inheritance of WebView from WebWidget to protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1918183004: Switch the inheritance of WebView from WebWidget to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/layout_test/layout_test_content_renderer_client.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

index 6cc2b53e7e13df9f672446230feaa58486cf3454..f3becd7d61894453c9634a5c2dc4c3a94a8b8792 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

@@ -35,6 +35,7 @@

#include "core/frame/LocalFrame.h"

#include "platform/geometry/FloatRect.h"

#include "public/platform/WebFileSystemType.h"

+#include "public/web/WebFrameWidget.h"

#include "public/web/WebLocalFrame.h"

#include "web/FrameLoaderClientImpl.h"

#include "web/UserMediaClientImpl.h"

@@ -59,7 +60,6 @@ class WebDataSourceImpl;

class WebDevToolsAgentImpl;

class WebDevToolsFrontendImpl;

class WebFrameClient;

-class WebFrameWidget;

class WebNode;

class WebPerformance;

class WebPlugin;

@@ -242,6 +242,7 @@ public:

void findMatchRects(WebVector<WebFloatRect>&) override;

int selectNearestFindMatch(const WebFloatPoint&, WebRect* selectionRect) override;

void setTickmarks(const WebVector<WebRect>&) override;

+ WebFrameWidget* frameWidget() const override;

// WebFrameImplBase methods:

void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& uniqueName) override;

@@ -319,7 +320,6 @@ public:

VisiblePosition visiblePositionForViewportPoint(const WebPoint&);

void setFrameWidget(WebFrameWidget*);

- WebFrameWidget* frameWidget() const;

// DevTools front-end bindings.

void setDevToolsFrontend(WebDevToolsFrontendImpl* frontend) { m_webDevToolsFrontend = frontend; }