Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/test_runner/test_runner_for_specific_view.cc

Issue 1918183004: Switch the inheritance of WebView from WebWidget to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner_for_specific_view.cc
diff --git a/components/test_runner/test_runner_for_specific_view.cc b/components/test_runner/test_runner_for_specific_view.cc
index 4476f3d210e0e0d190601966a61653a2b544098c..75b8d0d0475439642e4ecaf5c7329df7e73ab5d7 100644
--- a/components/test_runner/test_runner_for_specific_view.cc
+++ b/components/test_runner/test_runner_for_specific_view.cc
@@ -213,13 +213,20 @@ base::Closure TestRunnerForSpecificView::CreateClosureThatPostsV8Callback(
}
void TestRunnerForSpecificView::LayoutAndPaintAsync() {
- test_runner::LayoutAndPaintAsyncThen(web_view(), base::Closure());
+ // TODO(lfg, lukasza): TestRunnerForSpecificView assumes that there's a single
+ // WebWidget for the entire view, but with out-of-process iframes there may be
+ // multiple WebWidgets, one for each local root. We should look into making
+ // this structure more generic.
+ test_runner::LayoutAndPaintAsyncThen(
+ web_view()->mainFrame()->toWebLocalFrame()->frameWidget(),
+ base::Closure());
}
void TestRunnerForSpecificView::LayoutAndPaintAsyncThen(
v8::Local<v8::Function> callback) {
test_runner::LayoutAndPaintAsyncThen(
- web_view(), CreateClosureThatPostsV8Callback(callback));
+ web_view()->mainFrame()->toWebLocalFrame()->frameWidget(),
+ CreateClosureThatPostsV8Callback(callback));
}
void TestRunnerForSpecificView::CapturePixelsAsyncThen(
« no previous file with comments | « no previous file | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698