Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 1918183004: Switch the inheritance of WebView from WebWidget to protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 17 matching lines...) Expand all
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef WebLocalFrameImpl_h 31 #ifndef WebLocalFrameImpl_h
32 #define WebLocalFrameImpl_h 32 #define WebLocalFrameImpl_h
33 33
34 #include "core/editing/VisiblePosition.h" 34 #include "core/editing/VisiblePosition.h"
35 #include "core/frame/LocalFrame.h" 35 #include "core/frame/LocalFrame.h"
36 #include "platform/geometry/FloatRect.h" 36 #include "platform/geometry/FloatRect.h"
37 #include "public/platform/WebFileSystemType.h" 37 #include "public/platform/WebFileSystemType.h"
38 #include "public/web/WebFrameWidget.h"
38 #include "public/web/WebLocalFrame.h" 39 #include "public/web/WebLocalFrame.h"
39 #include "web/FrameLoaderClientImpl.h" 40 #include "web/FrameLoaderClientImpl.h"
40 #include "web/UserMediaClientImpl.h" 41 #include "web/UserMediaClientImpl.h"
41 #include "web/WebExport.h" 42 #include "web/WebExport.h"
42 #include "web/WebFrameImplBase.h" 43 #include "web/WebFrameImplBase.h"
43 #include "wtf/Compiler.h" 44 #include "wtf/Compiler.h"
44 #include "wtf/OwnPtr.h" 45 #include "wtf/OwnPtr.h"
45 #include "wtf/RefCounted.h" 46 #include "wtf/RefCounted.h"
46 #include "wtf/text/WTFString.h" 47 #include "wtf/text/WTFString.h"
47 48
48 namespace blink { 49 namespace blink {
49 50
50 class ChromePrintContext; 51 class ChromePrintContext;
51 class GeolocationClientProxy; 52 class GeolocationClientProxy;
52 class IntSize; 53 class IntSize;
53 class KURL; 54 class KURL;
54 class Range; 55 class Range;
55 class SharedWorkerRepositoryClientImpl; 56 class SharedWorkerRepositoryClientImpl;
56 class TextFinder; 57 class TextFinder;
57 class WebAutofillClient; 58 class WebAutofillClient;
58 class WebDataSourceImpl; 59 class WebDataSourceImpl;
59 class WebDevToolsAgentImpl; 60 class WebDevToolsAgentImpl;
60 class WebDevToolsFrontendImpl; 61 class WebDevToolsFrontendImpl;
61 class WebFrameClient; 62 class WebFrameClient;
62 class WebFrameWidget;
63 class WebNode; 63 class WebNode;
64 class WebPerformance; 64 class WebPerformance;
65 class WebPlugin; 65 class WebPlugin;
66 class WebPluginContainerImpl; 66 class WebPluginContainerImpl;
67 class WebScriptExecutionCallback; 67 class WebScriptExecutionCallback;
68 class WebSuspendableTask; 68 class WebSuspendableTask;
69 class WebView; 69 class WebView;
70 class WebViewImpl; 70 class WebViewImpl;
71 enum class WebFrameLoadType; 71 enum class WebFrameLoadType;
72 struct FrameLoadRequest; 72 struct FrameLoadRequest;
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 int identifier, const WebString& searchText, const WebFindOptions&, 236 int identifier, const WebString& searchText, const WebFindOptions&,
237 bool reset) override; 237 bool reset) override;
238 void cancelPendingScopingEffort() override; 238 void cancelPendingScopingEffort() override;
239 void increaseMatchCount(int count, int identifier) override; 239 void increaseMatchCount(int count, int identifier) override;
240 void resetMatchCount() override; 240 void resetMatchCount() override;
241 int findMatchMarkersVersion() const override; 241 int findMatchMarkersVersion() const override;
242 WebFloatRect activeFindMatchRect() override; 242 WebFloatRect activeFindMatchRect() override;
243 void findMatchRects(WebVector<WebFloatRect>&) override; 243 void findMatchRects(WebVector<WebFloatRect>&) override;
244 int selectNearestFindMatch(const WebFloatPoint&, WebRect* selectionRect) ove rride; 244 int selectNearestFindMatch(const WebFloatPoint&, WebRect* selectionRect) ove rride;
245 void setTickmarks(const WebVector<WebRect>&) override; 245 void setTickmarks(const WebVector<WebRect>&) override;
246 WebFrameWidget* frameWidget() const override;
dcheng 2016/05/04 04:55:30 Nit: let's call this widget (frame should be impli
lfg 2016/05/04 19:37:33 I'll do this in a separate patch, since there are
246 247
247 // WebFrameImplBase methods: 248 // WebFrameImplBase methods:
248 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& uniqueName) override; 249 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name, const AtomicString& uniqueName) override;
249 LocalFrame* frame() const override { return m_frame.get(); } 250 LocalFrame* frame() const override { return m_frame.get(); }
250 251
251 void willBeDetached(); 252 void willBeDetached();
252 void willDetachParent(); 253 void willDetachParent();
253 254
254 static WebLocalFrameImpl* create(WebTreeScopeType, WebFrameClient*, WebFrame * opener); 255 static WebLocalFrameImpl* create(WebTreeScopeType, WebFrameClient*, WebFrame * opener);
255 static WebLocalFrameImpl* createProvisional(WebFrameClient*, WebRemoteFrame* , WebSandboxFlags, const WebFrameOwnerProperties&); 256 static WebLocalFrameImpl* createProvisional(WebFrameClient*, WebRemoteFrame* , WebSandboxFlags, const WebFrameOwnerProperties&);
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 314
314 TextFinder* textFinder() const; 315 TextFinder* textFinder() const;
315 // Returns the text finder object if it already exists. 316 // Returns the text finder object if it already exists.
316 // Otherwise creates it and then returns. 317 // Otherwise creates it and then returns.
317 TextFinder& ensureTextFinder(); 318 TextFinder& ensureTextFinder();
318 319
319 // Returns a hit-tested VisiblePosition for the given point 320 // Returns a hit-tested VisiblePosition for the given point
320 VisiblePosition visiblePositionForViewportPoint(const WebPoint&); 321 VisiblePosition visiblePositionForViewportPoint(const WebPoint&);
321 322
322 void setFrameWidget(WebFrameWidget*); 323 void setFrameWidget(WebFrameWidget*);
323 WebFrameWidget* frameWidget() const;
324 324
325 // DevTools front-end bindings. 325 // DevTools front-end bindings.
326 void setDevToolsFrontend(WebDevToolsFrontendImpl* frontend) { m_webDevToolsF rontend = frontend; } 326 void setDevToolsFrontend(WebDevToolsFrontendImpl* frontend) { m_webDevToolsF rontend = frontend; }
327 WebDevToolsFrontendImpl* devToolsFrontend() { return m_webDevToolsFrontend; } 327 WebDevToolsFrontendImpl* devToolsFrontend() { return m_webDevToolsFrontend; }
328 328
329 WebNode contextMenuNode() const { return m_contextMenuNode.get(); } 329 WebNode contextMenuNode() const { return m_contextMenuNode.get(); }
330 void setContextMenuNode(Node* node) { m_contextMenuNode = node; } 330 void setContextMenuNode(Node* node) { m_contextMenuNode = node; }
331 void clearContextMenuNode() { m_contextMenuNode.clear(); } 331 void clearContextMenuNode() { m_contextMenuNode.clear(); }
332 332
333 DECLARE_TRACE(); 333 DECLARE_TRACE();
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 // Accomplish that by keeping a self-referential Persistent<>. It is 393 // Accomplish that by keeping a self-referential Persistent<>. It is
394 // cleared upon close(). 394 // cleared upon close().
395 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive; 395 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive;
396 }; 396 };
397 397
398 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame()); 398 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());
399 399
400 } // namespace blink 400 } // namespace blink
401 401
402 #endif 402 #endif
OLDNEW
« no previous file with comments | « content/shell/renderer/layout_test/layout_test_content_renderer_client.cc ('k') | third_party/WebKit/Source/web/WebViewImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698