mash: Close the system tray bubble on click outside its bounds

mash: Close the system tray bubble on click outside its bounds

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

Depends on https://codereview.chromium.org/1921673005/

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.

Committed: https://crrev.com/d6f1890e148dce5db019b2a6796f94f1e5a10be7
Cr-Commit-Position: refs/heads/master@{#390304}

[James Cook, 2016-04-26 16:42:34]

Description was changed from

==========
mash: Close the system tray bubble on click outside its bounds

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.
==========

to

==========
mash: Close the system tray bubble on click outside its bounds

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

Depends on https://codereview.chromium.org/1921673005/

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.
==========

[James Cook, 2016-04-26 16:42:56]

sky, please take a look. This is part 2.

[James Cook, 2016-04-26 19:33:31]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-04-26 19:33:32]

sky, please take a look.

[sky, 2016-04-26 21:43:38]

https://codereview.chromium.org/1918183003/diff/20001/ash/system/tray/tray_ev...
File ash/system/tray/tray_event_filter.cc (left):

https://codereview.chromium.org/1918183003/diff/20001/ash/system/tray/tray_ev...
ash/system/tray/tray_event_filter.cc:51: event->StopPropagation();
Do we not need to StopPropagation anymore?

[James Cook, 2016-04-26 23:23:45]

sky, please take another look

https://codereview.chromium.org/1918183003/diff/20001/ash/system/tray/tray_ev...
File ash/system/tray/tray_event_filter.cc (left):

https://codereview.chromium.org/1918183003/diff/20001/ash/system/tray/tray_ev...
ash/system/tray/tray_event_filter.cc:51: event->StopPropagation();
On 2016/04/26 21:43:38, sky wrote:
> Do we not need to StopPropagation anymore?

No we do not. This is the cause of the behavior change mentioned in the CL
description. We don't stop event propagation, so clicks outside the tray are
still handled, just like clicks outside of menus on windows.

This also means we don't have to repost events in the mus case.

[sky, 2016-04-26 23:41:55]

LGTM

[James Cook, 2016-04-28 04:29:27]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-04-28 04:29:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1918183003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-28 04:29:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918183003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918183003/80001

[commit-bot: I haz the power, 2016-04-28 05:04:40]

Description was changed from

==========
mash: Close the system tray bubble on click outside its bounds

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

Depends on https://codereview.chromium.org/1921673005/

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.
==========

to

==========
mash: Close the system tray bubble on click outside its bounds

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

Depends on https://codereview.chromium.org/1921673005/

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.
==========

[commit-bot: I haz the power, 2016-04-28 05:04:42]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-30 17:16:18]

Patchset 5 (id:??) landed as
https://crrev.com/d6f1890e148dce5db019b2a6796f94f1e5a10be7
Cr-Commit-Position: refs/heads/master@{#390304}

[commit-bot: I haz the power, 2016-04-30 17:54:15]

Description was changed from

==========
mash: Close the system tray bubble on click outside its bounds

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

Depends on https://codereview.chromium.org/1921673005/

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.
==========

to

==========
mash: Close the system tray bubble on click outside its bounds

* Use PointerWatcher to observe for clicks outside the widget bounds
* Add ScreenPositionClientMus to correctly transform the click locations

This changes the behavior of the system tray bubble on classic ash. Clicks
outside the bubble will now be handled (e.g. you can click outside the bubble
and start dragging a window). This is consistent with the menu behavior of
the hamburger menu and similar system tray bubbles on Windows. I've cleared
with PM kuscher@ that we want this behavior change.

Depends on https://codereview.chromium.org/1921673005/

BUG=599142
TEST=Run mash, click outside bubble, it closes. Ditto for ash. In both cases
you can start a window drag, click on a web page, etc. with the same click.

Committed: https://crrev.com/d6f1890e148dce5db019b2a6796f94f1e5a10be7
Cr-Commit-Position: refs/heads/master@{#390304}
==========