third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp - Issue 1918143007: Updated Blink WebVR interfaces to WebVR v1 spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp

Issue 1918143007: Updated Blink WebVR interfaces to WebVR v1 spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webvr_mojo

Patch Set: Fixed layout test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h ('k') | third_party/WebKit/Source/modules/vr/VRHardwareUnit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp

diff --git a/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp b/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp

index abfe797a23af8a6703ede28435e69e6407cbb587..83d7e929dc55889b3f36d4d6d3bcb383ecb2c4f9 100644

--- a/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp

+++ b/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.cpp

@@ -5,13 +5,13 @@

#include "modules/vr/VRGetDevicesCallback.h"

#include "bindings/core/v8/ScriptPromiseResolver.h"

-#include "modules/vr/VRHardwareUnitCollection.h"

+#include "modules/vr/VRDisplayCollection.h"

namespace blink {

-VRGetDevicesCallback::VRGetDevicesCallback(ScriptPromiseResolver* resolver, VRHardwareUnitCollection* hardwareUnits)

+VRGetDevicesCallback::VRGetDevicesCallback(ScriptPromiseResolver* resolver, VRDisplayCollection* displays)

: m_resolver(resolver)

- , m_hardwareUnits(hardwareUnits)

+ , m_displays(displays)

{

}

@@ -21,7 +21,7 @@ VRGetDevicesCallback::~VRGetDevicesCallback()

void VRGetDevicesCallback::onSuccess(const WebVector<WebVRDevice>& devices)

{

- m_resolver->resolve(m_hardwareUnits->updateVRHardwareUnits(devices));

+ m_resolver->resolve(m_displays->updateDisplays(devices));

}

void VRGetDevicesCallback::onError()