Add a serial number column to the certificate selector dialog and fix its size.

chrome/browser/ui/views/certificate_selector_browsertest.cc

Index: chrome/browser/ui/views/certificate_selector_browsertest.cc
diff --git a/chrome/browser/ui/views/certificate_selector_browsertest.cc b/chrome/browser/ui/views/certificate_selector_browsertest.cc
index e917720d11a6826101962496b50d8f42408cf9ad..6a7bdc9578a6caa197a719c8b3326634a89dc088 100644
--- a/chrome/browser/ui/views/certificate_selector_browsertest.cc
+++ b/chrome/browser/ui/views/certificate_selector_browsertest.cc
@@ -11,6 +11,7 @@
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/grit/generated_resources.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "content/public/test/browser_test_utils.h"
@@ -18,6 +19,7 @@
 #include "net/cert/x509_certificate.h"
 #include "net/test/cert_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/models/table_model.h"
 #include "ui/views/controls/label.h"
 
 namespace {
@@ -55,6 +57,8 @@ class TestCertificateSelector : public chrome::CertificateSelector {
     canceled_ = canceled;
   }
 
+  using chrome::CertificateSelector::table_model_for_testing;
+
   void set_on_destroy(base::Closure on_destroy) { on_destroy_ = on_destroy; }
 
  private:
@@ -102,6 +106,27 @@ class CertificateSelectorTest : public InProcessBrowserTest {
 
 }  // namespace
 
+IN_PROC_BROWSER_TEST_F(CertificateSelectorTest, GetRowText) {
+  ui::TableModel* model = selector_->table_model_for_testing();
+  EXPECT_EQ(base::UTF8ToUTF16("Client Cert A"),
+            model->GetText(0, IDS_CERT_SELECTOR_SUBJECT_COLUMN));
+  EXPECT_EQ(base::UTF8ToUTF16("B CA"),
+            model->GetText(0, IDS_CERT_SELECTOR_ISSUER_COLUMN));
+  EXPECT_EQ(base::UTF8ToUTF16(""),

[msw, 2016/04/29 18:04:54]

nit: use base::string16()

[meacer, 2016/04/29 21:50:53]

Done.

+            model->GetText(0, IDS_CERT_SELECTOR_PROVIDER_COLUMN));
+  EXPECT_EQ(base::UTF8ToUTF16("1000"),
+            model->GetText(0, IDS_CERT_SELECTOR_SERIAL_COLUMN));
+
+  EXPECT_EQ(base::UTF8ToUTF16("Client Cert D"),
+            model->GetText(1, IDS_CERT_SELECTOR_SUBJECT_COLUMN));
+  EXPECT_EQ(base::UTF8ToUTF16("E CA"),
+            model->GetText(1, IDS_CERT_SELECTOR_ISSUER_COLUMN));
+  EXPECT_EQ(base::UTF8ToUTF16(""),

[msw, 2016/04/29 18:04:54]

ditto

[meacer, 2016/04/29 21:50:53]

Done.

+            model->GetText(1, IDS_CERT_SELECTOR_PROVIDER_COLUMN));
+  EXPECT_EQ(base::UTF8ToUTF16("1002"),
+            model->GetText(1, IDS_CERT_SELECTOR_SERIAL_COLUMN));
+}
+
 IN_PROC_BROWSER_TEST_F(CertificateSelectorTest, GetSelectedCert) {
   EXPECT_EQ(client_1_.get(), selector_->GetSelectedCert());
   EXPECT_TRUE(ui_test_utils::SendKeyPressSync(browser(), ui::VKEY_DOWN, false,