chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc - Issue 1918133002: Disable DeclarativeContentApiTest.Overview (flaky).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

Issue 1918133002: Disable DeclarativeContentApiTest.Overview (flaky). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

index 00cfcc29ac01643eb568dc48e81c0cd7175e7a34..da8f13f7abfe8c307665c31dbd0bde891ac062d6 100644

--- a/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

+++ b/chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc

@@ -252,7 +252,8 @@ void DeclarativeContentApiTest::CheckBookmarkEvents(bool match_is_bookmarked) {

EXPECT_EQ(!match_is_bookmarked, page_action->GetIsVisible(tab_id));

}

-IN_PROC_BROWSER_TEST_F(DeclarativeContentApiTest, Overview) {

+// Disabled due to flake. https://crbug.com/606574.

+IN_PROC_BROWSER_TEST_F(DeclarativeContentApiTest, DISABLED_Overview) {

ext_dir_.WriteManifest(kDeclarativeContentManifest);

ext_dir_.WriteFile(

FILE_PATH_LITERAL("background.js"),

« no previous file with comments | « no previous file | no next file » | no next file with comments »