Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/fetch/MemoryCache.h

Issue 1918093003: Encapsulate |MemoryCacheEntry::m_resource| and refactor pruneDead/LiveResources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@MemoryCache_1a
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/MemoryCache.h
diff --git a/third_party/WebKit/Source/core/fetch/MemoryCache.h b/third_party/WebKit/Source/core/fetch/MemoryCache.h
index 529a08128d0fe16d5478b9695005812d743cad6c..5aa2222de5c589a7237de55dfe4f81bdfd07ab84 100644
--- a/third_party/WebKit/Source/core/fetch/MemoryCache.h
+++ b/third_party/WebKit/Source/core/fetch/MemoryCache.h
@@ -74,8 +74,8 @@ public:
}
DECLARE_TRACE();
void dispose();
+ Resource* resource();
- Member<Resource> m_resource;
bool m_inLiveDecodedResourcesList;
unsigned m_accessCount;
double m_lastDecodedAccessTime; // Used as a thrash guard
@@ -86,15 +86,17 @@ public:
Member<MemoryCacheEntry> m_nextInAllResourcesList;
private:
+ Member<Resource> m_resource;
Nate Chapin 2016/04/26 17:34:36 Nit: I think it's an unwritten convention that pri
+
explicit MemoryCacheEntry(Resource* resource)
- : m_resource(resource)
- , m_inLiveDecodedResourcesList(false)
+ : m_inLiveDecodedResourcesList(false)
, m_accessCount(0)
, m_lastDecodedAccessTime(0.0)
, m_previousInLiveResourcesList(nullptr)
, m_nextInLiveResourcesList(nullptr)
, m_previousInAllResourcesList(nullptr)
, m_nextInAllResourcesList(nullptr)
+ , m_resource(resource)
{
}
};

Powered by Google App Engine
This is Rietveld 408576698