Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: components/feedback/feedback_uploader_delegate.cc

Issue 1918083002: Convert //components/[f-n]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: … Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/feedback/feedback_uploader_delegate.h" 5 #include "components/feedback/feedback_uploader_delegate.h"
6 6
7 #include <memory>
7 #include <sstream> 8 #include <sstream>
8 9
9 #include "base/logging.h" 10 #include "base/logging.h"
10 #include "net/url_request/url_fetcher.h" 11 #include "net/url_request/url_fetcher.h"
11 12
12 namespace feedback { 13 namespace feedback {
13 namespace { 14 namespace {
14 15
15 const int kHttpPostSuccessNoContent = 204; 16 const int kHttpPostSuccessNoContent = 204;
16 const int kHttpPostFailNoConnection = -1; 17 const int kHttpPostFailNoConnection = -1;
17 const int kHttpPostFailClientError = 400; 18 const int kHttpPostFailClientError = 400;
18 const int kHttpPostFailServerError = 500; 19 const int kHttpPostFailServerError = 500;
19 20
20 } // namespace 21 } // namespace
21 22
22 FeedbackUploaderDelegate::FeedbackUploaderDelegate( 23 FeedbackUploaderDelegate::FeedbackUploaderDelegate(
23 const std::string& post_body, 24 const std::string& post_body,
24 const base::Closure& success_callback, 25 const base::Closure& success_callback,
25 const ReportDataCallback& error_callback) 26 const ReportDataCallback& error_callback)
26 : post_body_(post_body), 27 : post_body_(post_body),
27 success_callback_(success_callback), 28 success_callback_(success_callback),
28 error_callback_(error_callback) { 29 error_callback_(error_callback) {
29 } 30 }
30 31
31 FeedbackUploaderDelegate::~FeedbackUploaderDelegate() {} 32 FeedbackUploaderDelegate::~FeedbackUploaderDelegate() {}
32 33
33 void FeedbackUploaderDelegate::OnURLFetchComplete( 34 void FeedbackUploaderDelegate::OnURLFetchComplete(
34 const net::URLFetcher* source) { 35 const net::URLFetcher* source) {
35 scoped_ptr<const net::URLFetcher> source_scoper(source); 36 std::unique_ptr<const net::URLFetcher> source_scoper(source);
36 37
37 std::stringstream error_stream; 38 std::stringstream error_stream;
38 int response_code = source->GetResponseCode(); 39 int response_code = source->GetResponseCode();
39 if (response_code == kHttpPostSuccessNoContent) { 40 if (response_code == kHttpPostSuccessNoContent) {
40 error_stream << "Success"; 41 error_stream << "Success";
41 success_callback_.Run(); 42 success_callback_.Run();
42 } else { 43 } else {
43 // Process the error for debug output 44 // Process the error for debug output
44 if (response_code == kHttpPostFailNoConnection) { 45 if (response_code == kHttpPostFailNoConnection) {
45 error_stream << "No connection to server."; 46 error_stream << "No connection to server.";
46 } else if ((response_code > kHttpPostFailClientError) && 47 } else if ((response_code > kHttpPostFailClientError) &&
47 (response_code < kHttpPostFailServerError)) { 48 (response_code < kHttpPostFailServerError)) {
48 error_stream << "Client error: HTTP response code " << response_code; 49 error_stream << "Client error: HTTP response code " << response_code;
49 } else if (response_code > kHttpPostFailServerError) { 50 } else if (response_code > kHttpPostFailServerError) {
50 error_stream << "Server error: HTTP response code " << response_code; 51 error_stream << "Server error: HTTP response code " << response_code;
51 } else { 52 } else {
52 error_stream << "Unknown error: HTTP response code " << response_code; 53 error_stream << "Unknown error: HTTP response code " << response_code;
53 } 54 }
54 error_callback_.Run(post_body_); 55 error_callback_.Run(post_body_);
55 } 56 }
56 57
57 LOG(WARNING) << "FEEDBACK: Submission to feedback server (" 58 LOG(WARNING) << "FEEDBACK: Submission to feedback server ("
58 << source->GetURL() << ") status: " << error_stream.str(); 59 << source->GetURL() << ") status: " << error_stream.str();
59 60
60 // This instance won't be used for anything else, delete us. 61 // This instance won't be used for anything else, delete us.
61 delete this; 62 delete this;
62 } 63 }
63 64
64 } // namespace feedback 65 } // namespace feedback
OLDNEW
« no previous file with comments | « components/feedback/feedback_uploader.h ('k') | components/feedback/feedback_uploader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698