Convert //components/[f-n]* from scoped_ptr to std::unique_ptr

Convert //components/[f-n]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org,thestig@chromium.org

Committed: https://crrev.com/84c358e7a3b1658bf396d39716fb0fffbb0aa018
Cr-Commit-Position: refs/heads/master@{#389715}

[dcheng, 2016-04-26 00:11:42]

https://codereview.chromium.org/1918083002/diff/20001/components/feedback/fee...
File components/feedback/feedback_common.cc (right):

https://codereview.chromium.org/1918083002/diff/20001/components/feedback/fee...
components/feedback/feedback_common.cc:40: std::unique_ptr<std::string>
LogsToString(
I rewrote some bonus things in this file, because I had a hard time telling when
things were actually safe. So maybe take an extra close look at this file.

https://codereview.chromium.org/1918083002/diff/20001/components/ssl_errors/e...
File components/ssl_errors/error_classification_unittest.cc (right):

https://codereview.chromium.org/1918083002/diff/20001/components/ssl_errors/e...
components/ssl_errors/error_classification_unittest.cc:8: #include
"base/memory/scoped_ptr.h"
Meh. This might conflict a bit with the o-t CL. We'll see.

[danakj, 2016-04-26 01:36:51]

Some new stuff in chrome/ :)

chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc:101:3:
erro

https://codereview.chromium.org/1918083002/diff/20001/components/ssl_errors/e...
File components/ssl_errors/error_classification_unittest.cc (right):

https://codereview.chromium.org/1918083002/diff/20001/components/ssl_errors/e...
components/ssl_errors/error_classification_unittest.cc:8: #include
"base/memory/scoped_ptr.h"
On 2016/04/26 00:11:42, dcheng wrote:
> Meh. This might conflict a bit with the o-t CL. We'll see.

Rebase on top of it (and git branch -u it) and rietveld will include it as a
dependent for trybots.

[danakj, 2016-04-26 01:40:16]

LGTM

https://codereview.chromium.org/1918083002/diff/20001/components/keyed_servic...
File components/keyed_service/core/keyed_service_factory.h (right):

https://codereview.chromium.org/1918083002/diff/20001/components/keyed_servic...
components/keyed_service/core/keyed_service_factory.h:36: typedef
std::unique_ptr<KeyedService> (*TestingFactoryFunction)(
using if u want

[dcheng, 2016-04-26 03:55:45]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-26 03:55:46]

Hopefully fixed the build too.

https://codereview.chromium.org/1918083002/diff/20001/components/keyed_servic...
File components/keyed_service/core/keyed_service_factory.h (right):

https://codereview.chromium.org/1918083002/diff/20001/components/keyed_servic...
components/keyed_service/core/keyed_service_factory.h:36: typedef
std::unique_ptr<KeyedService> (*TestingFactoryFunction)(
On 2016/04/26 at 01:40:16, danakj wrote:
> using if u want

done.

[dcheng, 2016-04-26 03:55:47]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1918083002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-04-26 03:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918083002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918083002/40001

[commit-bot: I haz the power, 2016-04-26 04:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 04:13:01]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dcheng, 2016-04-26 04:17:50]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-26 04:17:50]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1918083002/#ps60001
(title: "Really fix build")

[commit-bot: I haz the power, 2016-04-26 04:18:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918083002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918083002/60001

[commit-bot: I haz the power, 2016-04-26 04:35:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 04:35:37]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[dcheng, 2016-04-26 04:38:30]

dcheng@chromium.org changed reviewers:
+ thestig@chromium.org

[dcheng, 2016-04-26 04:38:31]

+thestig as well since there are some (trivial) fixes in //chrome now as well.

[dcheng, 2016-04-26 04:38:38]

Description was changed from

==========
Convert //components/[f-n]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org
==========

to

==========
Convert //components/[f-n]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org,thestig@chromium.org
==========

[dcheng, 2016-04-26 04:38:39]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-26 04:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1918083002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-04-26 04:38:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918083002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918083002/80001

[commit-bot: I haz the power, 2016-04-26 04:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 04:57:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-04-26 05:46:52]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-26 05:46:52]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1918083002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-04-26 05:47:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918083002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918083002/100001

[Lei Zhang, 2016-04-26 05:55:21]

On 2016/04/26 04:57:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Looks like another one snuck in. :-P

chrome/ lgtm

[commit-bot: I haz the power, 2016-04-26 06:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 06:06:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-04-26 06:16:16]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-26 06:16:17]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1918083002/#ps120001
(title: "…")

[commit-bot: I haz the power, 2016-04-26 06:16:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918083002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918083002/120001

[commit-bot: I haz the power, 2016-04-26 07:06:56]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-26 07:08:51]

Description was changed from

==========
Convert //components/[f-n]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org,thestig@chromium.org
==========

to

==========
Convert //components/[f-n]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org,thestig@chromium.org

Committed: https://crrev.com/84c358e7a3b1658bf396d39716fb0fffbb0aa018
Cr-Commit-Position: refs/heads/master@{#389715}
==========

[commit-bot: I haz the power, 2016-04-26 07:08:52]

Patchset 7 (id:??) landed as
https://crrev.com/84c358e7a3b1658bf396d39716fb0fffbb0aa018
Cr-Commit-Position: refs/heads/master@{#389715}