MD Settings: Search engines, use favicon cache.

chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
index 95d61f3c860ad729e3ee34cc43b8e2693136e59d..db595ebbabcea588ab8ee96d931c9d2637db36f7 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
@@ -1,9 +1,8 @@
 <link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/html/util.html">

[Dan Beam, 2016/04/26 22:33:14]

totally optional nit: maybe alpha if dependency order is agnostic?

[dpapad, 2016/04/26 22:43:25]

Sorted, partially. I am still reluctant not placing polymer.html at the very
top, because of the logic at
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources....

You might end up using the shady DOM if search_engine_entry.html was the only
HTML imported on a page (not the case for prod code, but could happen in testing
code).

 <link rel="import" href="chrome://md-settings/search_engines_page/search_engine_dialog.html">
 <link rel="import" href="chrome://md-settings/search_engines_page/search_engines_browser_proxy.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-dropdown.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
 <link rel="import" href="chrome://md-settings/settings_shared_css.html">
@@ -36,14 +35,8 @@
     </template>
     <div id="container" class="list-item">
       <div class="name-column">
-        <span class="icon-container">
-          <template is="dom-if" if="[[engine.iconURL]]">
-            <iron-icon src="[[engine.iconURL]]"></iron-icon>
-          </template>
-          <template is="dom-if" if="[[!engine.iconURL]]">
-            <iron-icon icon="icons:find-in-page"></iron-icon>
-          </template>
-        </span>
+        <span class="favicon-image"
+            style="background-image: [[getIconSet_(engine.iconURL)]]"></span>
         <span class="name">[[engine.displayName]]</span>
       </div>
       <div class="keyword-column">[[engine.keyword]]</div>