Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Issue 1918053002: MD Settings: Search engines, use favicon cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Handle missing iconURL case. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-search-engine-entry' is a component for showing a 6 * @fileoverview 'settings-search-engine-entry' is a component for showing a
7 * search engine with its name, domain and query URL. 7 * search engine with its name, domain and query URL.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-search-engine-entry', 10 is: 'settings-search-engine-entry',
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 /** @private */ 64 /** @private */
65 onMakeDefaultTap_: function() { 65 onMakeDefaultTap_: function() {
66 this.closePopupMenu_(); 66 this.closePopupMenu_();
67 this.browserProxy_.setDefaultSearchEngine(this.engine.modelIndex); 67 this.browserProxy_.setDefaultSearchEngine(this.engine.modelIndex);
68 }, 68 },
69 69
70 /** @private */ 70 /** @private */
71 closePopupMenu_: function() { 71 closePopupMenu_: function() {
72 this.$$('iron-dropdown').close(); 72 this.$$('iron-dropdown').close();
73 }, 73 },
74
75 /**
76 * @param {?string} url The icon URL if available.
77 * @return {string} A set of icon URLs.
78 * @private
79 */
80 getIconSet_: function(url) {
81 // Force default icon, if no |engine.iconURL| is available.
82 return getFaviconImageSet(url || '');
83 },
74 }); 84 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/search_engine_entry.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698