Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: test/codegen/expect/fieldtest.js

Issue 1918033002: Remove virtualField helper, just emit getters/setters in codegen. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/compiler/code_generator.dart ('k') | test/codegen/expect/language-all.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/codegen/expect/fieldtest.js
diff --git a/test/codegen/expect/fieldtest.js b/test/codegen/expect/fieldtest.js
index 2b281cb32900d780d4d3035bed59c66e16a53927..cd6407ccc312f09b951d0ae7e2aefc7d6be65a7f 100644
--- a/test/codegen/expect/fieldtest.js
+++ b/test/codegen/expect/fieldtest.js
@@ -66,11 +66,17 @@ dart_library.library('fieldtest', null, /* Imports */[
};
fieldtest.Derived = class Derived extends fieldtest.BaseWithGetter {
Derived() {
- this.foo = 2;
+ this[foo] = 2;
this.bar = 3;
}
+ get foo() {
+ return this[foo];
+ }
+ set foo(value) {
+ this[foo] = value;
+ }
};
- dart.virtualField(fieldtest.Derived, 'foo');
+ const foo = Symbol(fieldtest.Derived.name + "." + 'foo'.toString());
fieldtest.Generic$ = dart.generic(T => {
class Generic extends core.Object {
foo(t) {
« no previous file with comments | « lib/src/compiler/code_generator.dart ('k') | test/codegen/expect/language-all.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698