Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: lib/runtime/dart_sdk.js

Side-by-side diff isn't available for this file because of its large size.
Issue 1918033002: Remove virtualField helper, just emit getters/setters in codegen. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/src/compiler/code_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index 3a33f39518d8144d2ced401cb3c83052fe40bc72..46df181d3cf562c6112629995d80f7cffca4916d 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -179,19 +179,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
dart.hasMethod = function(obj, name) {
return dart.getMethodType(obj, name) !== void 0;
};
- dart.virtualField = function(subclass, fieldName) {
- let prop = dart.getOwnPropertyDescriptor(subclass.prototype, fieldName);
- if (prop) return;
- let symbol = Symbol(subclass.name + '.' + fieldName.toString());
- dart.defineProperty(subclass.prototype, fieldName, {
- get: function() {
- return this[symbol];
- },
- set: function(x) {
- this[symbol] = x;
- }
- });
- };
dart.defineNamedConstructor = function(clazz, name) {
let proto = clazz.prototype;
let initMethod = proto[name];
« no previous file with comments | « no previous file | lib/src/compiler/code_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698