Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: test/codegen/expect/fieldtest.js

Issue 1918033002: Remove virtualField helper, just emit getters/setters in codegen. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 dart_library.library('fieldtest', null, /* Imports */[ 1 dart_library.library('fieldtest', null, /* Imports */[
2 'dart_sdk' 2 'dart_sdk'
3 ], function(exports, dart_sdk) { 3 ], function(exports, dart_sdk) {
4 'use strict'; 4 'use strict';
5 const core = dart_sdk.core; 5 const core = dart_sdk.core;
6 const dart = dart_sdk.dart; 6 const dart = dart_sdk.dart;
7 const dartx = dart_sdk.dartx; 7 const dartx = dart_sdk.dartx;
8 const fieldtest = Object.create(null); 8 const fieldtest = Object.create(null);
9 fieldtest.A = class A extends core.Object { 9 fieldtest.A = class A extends core.Object {
10 A() { 10 A() {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 fieldtest.BaseWithGetter = class BaseWithGetter extends core.Object { 62 fieldtest.BaseWithGetter = class BaseWithGetter extends core.Object {
63 get foo() { 63 get foo() {
64 return 1; 64 return 1;
65 } 65 }
66 }; 66 };
67 fieldtest.Derived = class Derived extends fieldtest.BaseWithGetter { 67 fieldtest.Derived = class Derived extends fieldtest.BaseWithGetter {
68 Derived() { 68 Derived() {
69 this.foo = 2; 69 this.foo = 2;
70 this.bar = 3; 70 this.bar = 3;
71 } 71 }
72 get foo() {
73 return this[foo];
74 }
75 set foo(value) {
76 this[foo] = value;
77 }
72 }; 78 };
73 dart.virtualField(fieldtest.Derived, 'foo'); 79 const foo = Symbol(fieldtest.Derived.name + "." + 'foo'.toString());
74 fieldtest.Generic$ = dart.generic(T => { 80 fieldtest.Generic$ = dart.generic(T => {
75 class Generic extends core.Object { 81 class Generic extends core.Object {
76 foo(t) { 82 foo(t) {
77 dart.as(t, T); 83 dart.as(t, T);
78 return core.print(dart.notNull(fieldtest.Generic.bar) + dart.notNull(dar t.as(t, core.String))); 84 return core.print(dart.notNull(fieldtest.Generic.bar) + dart.notNull(dar t.as(t, core.String)));
79 } 85 }
80 } 86 }
81 dart.setSignature(Generic, { 87 dart.setSignature(Generic, {
82 methods: () => ({foo: [dart.dynamic, [T]]}) 88 methods: () => ({foo: [dart.dynamic, [T]]})
83 }); 89 });
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 fieldtest.foo(a); 140 fieldtest.foo(a);
135 fieldtest.bar(a); 141 fieldtest.bar(a);
136 core.print(fieldtest.baz(a)); 142 core.print(fieldtest.baz(a));
137 core.print(new (fieldtest.Generic$(core.String))().foo(' world')); 143 core.print(new (fieldtest.Generic$(core.String))().foo(' world'));
138 core.print(fieldtest.MyEnum.values); 144 core.print(fieldtest.MyEnum.values);
139 }; 145 };
140 dart.fn(fieldtest.main, dart.void, []); 146 dart.fn(fieldtest.main, dart.void, []);
141 // Exports: 147 // Exports:
142 exports.fieldtest = fieldtest; 148 exports.fieldtest = fieldtest;
143 }); 149 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698