Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1917993004: [es8] Initial set of changes to support syntactic tail calls. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Igor Sheludko
Modified:
1 year, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es8] Initial set of changes to support syntactic tail calls. The syntax is "return continue expr;". BUG=v8:4915 LOG=Y Committed: https://crrev.com/ea2fbb7620bdd48ef53196b2dbc79554bb48389a Cr-Commit-Position: refs/heads/master@{#35799}

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -133 lines) Patch
M src/messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 1 6 chunks +35 lines, -40 lines 0 comments Download
M src/parsing/parser-base.h View 1 7 chunks +66 lines, -6 lines 0 comments Download
M src/parsing/preparser.cc View 1 6 chunks +37 lines, -2 lines 0 comments Download
A + test/message/syntactic-tail-call-in-try.js View 1 chunk +7 lines, -6 lines 0 comments Download
A test/message/syntactic-tail-call-in-try.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/syntactic-tail-call-in-try-catch-finally.js View 1 chunk +10 lines, -6 lines 0 comments Download
A test/message/syntactic-tail-call-in-try-catch-finally.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/message/syntactic-tail-call-in-try-try-catch-finally.js View 1 chunk +13 lines, -8 lines 0 comments Download
A test/message/syntactic-tail-call-in-try-try-catch-finally.out View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/es7/syntactic-tail-call.js View 19 chunks +37 lines, -29 lines 0 comments Download
A + test/mjsunit/es7/syntactic-tail-call-simple.js View 6 chunks +12 lines, -34 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917993004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917993004/40001
1 year, 2 months ago (2016-04-26 14:31:12 UTC) #5
Igor Sheludko
PTAL
1 year, 2 months ago (2016-04-26 14:31:15 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
1 year, 2 months ago (2016-04-26 14:55:34 UTC) #9
rossberg
I think this is good as a first step. We can do proper parsing of ...
1 year, 2 months ago (2016-04-26 14:56:58 UTC) #10
Igor Sheludko
https://codereview.chromium.org/1917993004/diff/40001/src/parsing/parser-base.h File src/parsing/parser-base.h (right): https://codereview.chromium.org/1917993004/diff/40001/src/parsing/parser-base.h#newcode2930 src/parsing/parser-base.h:2930: if (is_tail_call_expression) { On 2016/04/26 14:56:57, rossberg wrote: > ...
1 year, 2 months ago (2016-04-26 16:48:17 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917993004/60001
1 year, 2 months ago (2016-04-26 16:48:42 UTC) #14
rossberg
lgtm
1 year, 2 months ago (2016-04-26 16:51:48 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
1 year, 2 months ago (2016-04-26 17:27:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917993004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917993004/60001
1 year, 2 months ago (2016-04-26 17:28:05 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:60001)
1 year, 2 months ago (2016-04-26 17:30:27 UTC) #21
commit-bot: I haz the power
1 year, 2 months ago (2016-04-26 17:31:35 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea2fbb7620bdd48ef53196b2dbc79554bb48389a
Cr-Commit-Position: refs/heads/master@{#35799}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 23e94e589