Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1917923002: Reland "Check for semaphore alignment on posix platforms. (patchset #1 id:1 of https://codereview.c… (Closed)

Created:
4 years, 8 months ago by ulan
Modified:
4 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Check for semaphore alignment on posix platforms. (patchset #1 id:1 of https://codereview.chromium.org/1912923003/ )" This patch also fixed three misaligned semaphores. This reverts commit 80c73e2cde6020f8a3879408bee72828e887e3d5. BUG=chromium:605349 LOG=NO Committed: https://crrev.com/67f3103a26055e166b67b9769bfaf0c575b92154 Cr-Commit-Position: refs/heads/master@{#35773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/base/platform/semaphore.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/libplatform/task-queue.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 8 months ago (2016-04-25 17:34:37 UTC) #2
Michael Lippautz
lgtm
4 years, 8 months ago (2016-04-25 17:42:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917923002/1
4 years, 8 months ago (2016-04-25 17:45:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 18:11:19 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 18:12:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67f3103a26055e166b67b9769bfaf0c575b92154
Cr-Commit-Position: refs/heads/master@{#35773}

Powered by Google App Engine
This is Rietveld 408576698