Optimize the task to re-resolve instance fields (issue 26306)

Optimize the task to re-resolve instance fields (issue 26306)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/32400bd49d218f8372f19358c846ef3c4550f3d4

[Brian Wilkerson, 2016-04-25 20:28:46]

Description was changed from

==========
Optimize the task to re-resolve instance fields
==========

to

==========
Optimize the task to re-resolve instance fields (issue 26306)
==========

[Brian Wilkerson, 2016-04-25 20:32:00]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2016-04-25 20:32:01]

This cut the time for the task roughly in half (based on some ad-hoc
measurements that are probably not very accurate).

[scheglov, 2016-04-25 20:45:56]

LGTM

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4922: * [typeProvider]. The
[inheritanceManager] is used to perform inheritance
1. AFAIK LibraryScope does not need TypeProvider.

2. It seems that other parameter after this point don't exist.

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4972: for (int i = 0; i <
members.length; i++) {
Do we want to extract members.length as we do for declarations.length above?

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4991: for (VariableDeclaration
field in node.fields.variables) {
Do we need to check that it is an instance (not static) class?

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4994: initializer.accept(this);
field.initializer?.accept(this) maybe?

[Brian Wilkerson, 2016-04-25 21:08:40]

Description was changed from

==========
Optimize the task to re-resolve instance fields (issue 26306)
==========

to

==========
Optimize the task to re-resolve instance fields (issue 26306)

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/32400bd49d218f8372f19358c846ef3c4550f3d4
==========

[Brian Wilkerson, 2016-04-25 21:08:41]

Committed patchset #2 (id:20001) manually as
32400bd49d218f8372f19358c846ef3c4550f3d4 (presubmit successful).

[Brian Wilkerson, 2016-04-25 21:08:59]

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4922: * [typeProvider]. The
[inheritanceManager] is used to perform inheritance
Done. The comment was copied from elsewhere and I forgot to clean it up. Thanks!

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4972: for (int i = 0; i <
members.length; i++) {
Done

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4991: for (VariableDeclaration
field in node.fields.variables) {
Done

https://codereview.chromium.org/1917893003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:4994: initializer.accept(this);
Done