Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 1917883002: Remove TraceWrappers idl attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove incomplete traceWrappers method on dom/Node Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
index 6e565e4fca5178fc0694197622afc4e3dae4447b..c448a0ab2ab7a8758200c85982a0b08e17120eb5 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py
@@ -150,11 +150,6 @@ def interface_context(interface):
has_extended_attribute_value(interface, 'Custom', 'VisitDOMWrapper') or
set_wrapper_reference_from or set_wrapper_reference_to)
- # [TraceWrappers]
- trace_wrappers = extended_attribute_value_as_list(interface, 'TraceWrappers')
- if trace_wrappers:
- includes.add('bindings/core/v8/ScriptWrappableVisitor.h')
-
wrapper_class_id = ('NodeClassId' if inherits_interface(interface.name, 'Node') else 'ObjectClassId')
v8_class_name = v8_utilities.v8_class_name(interface)
@@ -173,7 +168,6 @@ def interface_context(interface):
'has_custom_legacy_call_as_function': has_extended_attribute_value(interface, 'Custom', 'LegacyCallAsFunction'), # [Custom=LegacyCallAsFunction]
'has_partial_interface': len(interface.partial_interfaces) > 0,
'has_visit_dom_wrapper': has_visit_dom_wrapper,
- 'trace_wrappers': trace_wrappers,
'header_includes': header_includes,
'interface_name': interface.name,
'is_array_buffer_or_view': is_array_buffer_or_view,
@@ -184,7 +178,7 @@ def interface_context(interface):
'is_node': inherits_interface(interface.name, 'Node'),
'is_partial': interface.is_partial,
'is_typed_array_type': is_typed_array_type,
- 'lifetime': 'Dependent' if (has_visit_dom_wrapper or trace_wrappers or is_dependent_lifetime) else 'Independent',
+ 'lifetime': 'Dependent' if (has_visit_dom_wrapper or is_dependent_lifetime) else 'Independent',
'measure_as': v8_utilities.measure_as(interface, None), # [MeasureAs]
'origin_trial_enabled_function': v8_utilities.origin_trial_enabled_function_name(interface, None),
'parent_interface': parent_interface,

Powered by Google App Engine
This is Rietveld 408576698