Remove TraceWrappers idl attribute

Remove TraceWrappers idl attribute

It turns out that we don't have to trace as much as expected, plus automation
cannot often be applied anyway. So let's just get rid of it and write traceWrapper
methods by hand.

LOG=no
BUG=468240
Committed: https://crrev.com/5ef4df517486edec05d4cca3e56c5eeedb11847a
Cr-Commit-Position: refs/heads/master@{#389864}

[Marcel Hlopko, 2016-04-25 15:02:01]

Description was changed from

==========
Remove TraceWrappers idl attribute

It turns out that we don't have to trace as much as expected, plus automation
cannot often be applied. So let's just get rid of it and write traceWrapper
methods by hand.

LOG=no
BUG=468240
==========

to

==========
Remove TraceWrappers idl attribute

It turns out that we don't have to trace as much as expected, plus automation
cannot often be applied anyway. So let's just get rid of it and write
traceWrapper
methods by hand.

LOG=no
BUG=468240
==========

[Marcel Hlopko, 2016-04-25 15:02:01]

hlopko@chromium.org changed reviewers:
+ haraken@chromium.org, hpayer@chromium.org, jochen@chromium.org

[Marcel Hlopko, 2016-04-25 15:02:11]

Ptal

[haraken, 2016-04-25 15:19:53]

LGTM

https://codereview.chromium.org/1917883002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/1917883002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Node.cpp:2267: DEFINE_TRACE_WRAPPERS(Node)

Shall we remove the tracing method for now? EventTarget doesn't yet have
traceWrappers.

We can introduce the tracing method when we actually replace the object grouping
with traceWrappers.

[Marcel Hlopko, 2016-04-25 15:22:34]

https://codereview.chromium.org/1917883002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/1917883002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Node.cpp:2267: DEFINE_TRACE_WRAPPERS(Node)
Done.

[Marcel Hlopko, 2016-04-25 15:22:39]

The CQ bit was checked by hlopko@chromium.org

[Marcel Hlopko, 2016-04-25 15:22:39]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1917883002/#ps20001
(title: "Remove incomplete traceWrappers method on dom/Node")

[commit-bot: I haz the power, 2016-04-25 15:22:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917883002/20001

[commit-bot: I haz the power, 2016-04-25 15:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 15:29:40]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Marcel Hlopko, 2016-04-26 18:06:45]

The CQ bit was checked by hlopko@chromium.org

[commit-bot: I haz the power, 2016-04-26 18:07:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917883002/20001

[commit-bot: I haz the power, 2016-04-26 20:03:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 20:05:08]

Description was changed from

==========
Remove TraceWrappers idl attribute

It turns out that we don't have to trace as much as expected, plus automation
cannot often be applied anyway. So let's just get rid of it and write
traceWrapper
methods by hand.

LOG=no
BUG=468240
==========

to

==========
Remove TraceWrappers idl attribute

It turns out that we don't have to trace as much as expected, plus automation
cannot often be applied anyway. So let's just get rid of it and write
traceWrapper
methods by hand.

LOG=no
BUG=468240

Committed: https://crrev.com/5ef4df517486edec05d4cca3e56c5eeedb11847a
Cr-Commit-Position: refs/heads/master@{#389864}
==========

[commit-bot: I haz the power, 2016-04-26 20:05:09]

Patchset 2 (id:??) landed as
https://crrev.com/5ef4df517486edec05d4cca3e56c5eeedb11847a
Cr-Commit-Position: refs/heads/master@{#389864}