Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 7 months ago by Bret Modified:
4 years, 7 months ago Reviewers:
iannucci, scottmg, tandrii(chromium) CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, scottmg, brucedawson Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionSubprocess uses shell=True on Windows when launching GN.
BUG=600051
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300311
Patch Set 1 #
Total comments: 4
Patch Set 2 : fix nits #Messages
Total messages: 14 (7 generated)
Description was changed from ========== Subprocess uses shell=True on Windows when launching GN. BUG=600051 ========== to ========== Subprocess uses shell=True on Windows when launching GN. BUG=600051 ==========
bsep@chromium.org changed reviewers: + iannucci@chromium.org
scottmg@chromium.org changed reviewers: + scottmg@chromium.org
lgtm https://codereview.chromium.org/1917863009/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1917863009/diff/1/git_cl.py#newcode4752 git_cl.py:4752: cwd=top_dir, Swap the order of cwd= and shell=, since shell= is going into a named argument and cwd= is going into **kwargs. https://codereview.chromium.org/1917863009/diff/1/git_cl.py#newcode4753 git_cl.py:4753: shell=(sys.platform == 'win32')) nit; I would remove the parens around (sys.platform == 'win32').
lgtm
https://codereview.chromium.org/1917863009/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1917863009/diff/1/git_cl.py#newcode4752 git_cl.py:4752: cwd=top_dir, On 2016/04/28 23:49:43, scottmg wrote: > Swap the order of cwd= and shell=, since shell= is going into a named argument > and cwd= is going into **kwargs. Done. https://codereview.chromium.org/1917863009/diff/1/git_cl.py#newcode4753 git_cl.py:4753: shell=(sys.platform == 'win32')) On 2016/04/28 23:49:43, scottmg wrote: > nit; I would remove the parens around (sys.platform == 'win32'). Done.
The CQ bit was checked by bsep@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from iannucci@chromium.org, scottmg@chromium.org Link to the patchset: https://codereview.chromium.org/1917863009/#ps20001 (title: "fix nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917863009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917863009/20001
Message was sent while issue was closed.
Description was changed from ========== Subprocess uses shell=True on Windows when launching GN. BUG=600051 ========== to ========== Subprocess uses shell=True on Windows when launching GN. BUG=600051 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300311 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300311
Message was sent while issue was closed.
tandrii@chromium.org changed reviewers: + tandrii@chromium.org
Message was sent while issue was closed.
LGTM |
