lib/src/compiler/module_builder.dart - Issue 1917863005: Qualify library names in packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/compiler/module_builder.dart

Issue 1917863005: Qualify library names in packages (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/compiler/module_builder.dart

diff --git a/lib/src/compiler/module_builder.dart b/lib/src/compiler/module_builder.dart

index 0b2be9159c0d21123dffe4184d179ea5b4f44e84..98e358544d867b824b269e6540672186b96bc22e 100644

--- a/lib/src/compiler/module_builder.dart

+++ b/lib/src/compiler/module_builder.dart

@@ -150,7 +150,7 @@ class NodeModuleBuilder extends _ModuleBuilder {

/// Escape [name] to make it into a valid identifier.

String pathToJSIdentifier(String name) {

- name = path.basenameWithoutExtension(name);

+ name = path.withoutExtension(name);

Jennifer Messerly 2016/04/26 22:59:33 hmmm, this change seems bad for absolute paths, ar

if (name.length == 0) return r'$';

// Escape any invalid characters