Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1917863002: Replace _analyzeElementEagerly with Resolution.ensureResolved (Closed)

Created:
4 years, 8 months ago by Johnni Winther
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace _analyzeElementEagerly with Resolution.ensureResolved R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/4c9e6ff3450f85d920986f1f2e991be7b622a325

Patch Set 1 #

Patch Set 2 : dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 4 chunks +4 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +14 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_test_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 8 months ago (2016-04-25 14:50:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-25 15:21:39 UTC) #3
Johnni Winther
4 years, 8 months ago (2016-04-26 07:54:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4c9e6ff3450f85d920986f1f2e991be7b622a325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698