Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: build/common.gypi

Issue 1917853002: roll clang 266460:267383 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tweakflags Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 9368049d22e875e640a8f46e0963cbc5f63a44f8..009e209f215808a04e0f0c9917d9509648de0b37 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2657,6 +2657,9 @@
# TODO(thakis): Enable this, crbug.com/507717
'-Wno-shift-negative-value',
+
+ # TODO(thakis): https://crbug.com/604888
+ '-Wno-undefined-var-template',
],
},
'includes': [ 'set_clang_warning_flags.gypi', ],
@@ -3074,10 +3077,6 @@
# TODO: Enable on Windows too, http://crbug.com/404525
'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
}],
- ['"<!(python <(DEPTH)/tools/clang/scripts/update.py --print-revision)"!="266460-1"', {
- # TODO(thakis): https://crbug.com/604888
- 'variables': { 'clang_warning_flags': ['-Wno-undefined-var-template']},
- }],
['chromium_code==0', {
'variables': {
'clang_warning_flags': [
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698