Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1917853002: roll clang 266460:267383 (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

roll clang 266460:267383 Also switch to gnuwin-3, which is identical to gnuwin-1 (which is a zip of all binaries from GnuWin32 needed to run llvm regression tests), except that rm.exe, mv.exe and find.exe have been replaced with rm.exe, mv.exe, and find.exe from msys (and three msys dlls needed to run them have been added). This new rm.exe is able to delete paths longer than 260 characters, needed for clang's Modules/dependency-dump.m test, and the new mv.exe is needed for ExecutionEngine/OrcMCJIT/load-object-a.ll which moves long paths around with `find.exe -exec mv.exe` BUG=604993, 603364 Committed: https://crrev.com/8aa292dd634877fc41e5844af23d1dee28694f41 Cr-Commit-Position: refs/heads/master@{#389632}

Patch Set 1 #

Patch Set 2 : find and mv too #

Patch Set 3 : tweakflags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M build/common.gypi View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M tools/clang/scripts/update.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Nico
4 years, 8 months ago (2016-04-25 20:33:02 UTC) #6
hans
lgtm if the bots go green *yay* for green win_upload_clang
4 years, 8 months ago (2016-04-25 20:35:58 UTC) #7
Nico
patch set 3 moves -Wno-undefined-var-template out of the "tot only" block
4 years, 8 months ago (2016-04-25 20:52:49 UTC) #8
hans
On 2016/04/25 20:52:49, Nico wrote: > patch set 3 moves -Wno-undefined-var-template out of the "tot ...
4 years, 8 months ago (2016-04-25 20:56:20 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917853002/40001
4 years, 8 months ago (2016-04-25 21:26:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917853002/40001
4 years, 8 months ago (2016-04-25 23:20:39 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 00:24:49 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:27:28 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8aa292dd634877fc41e5844af23d1dee28694f41
Cr-Commit-Position: refs/heads/master@{#389632}

Powered by Google App Engine
This is Rietveld 408576698