Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 191783002: Reorder View Textfield and Omnibox overrides. (Closed)

Created:
6 years, 9 months ago by msw
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su
Visibility:
Public.

Description

Reorder View Textfield and Omnibox overrides. Subclass overrides should match base class decls. No other changes, just reordering functions. BUG=131660 TEST=none TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -237 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 3 chunks +38 lines, -38 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 2 chunks +12 lines, -13 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 4 chunks +183 lines, -183 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
msw
Hey Scott, take a look as you have time; landing.
6 years, 9 months ago (2014-03-08 01:42:47 UTC) #1
msw
The CQ bit was checked by msw@chromium.org
6 years, 9 months ago (2014-03-08 01:42:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/191783002/1
6 years, 9 months ago (2014-03-08 11:20:59 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 11:49:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-08 11:49:03 UTC) #5
msw
The CQ bit was checked by msw@chromium.org
6 years, 9 months ago (2014-03-08 19:44:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/191783002/1
6 years, 9 months ago (2014-03-08 19:44:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 20:48:51 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234564
6 years, 9 months ago (2014-03-08 20:48:51 UTC) #9
msw
The CQ bit was checked by msw@chromium.org
6 years, 9 months ago (2014-03-09 16:57:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/191783002/1
6 years, 9 months ago (2014-03-09 16:57:26 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 17:45:26 UTC) #12
Message was sent while issue was closed.
Change committed as 255857

Powered by Google App Engine
This is Rietveld 408576698