third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp - Issue 1917733004: Reland of: Make OffscreenCanvas Transferable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

Issue 1917733004: Reland of: Make OffscreenCanvas Transferable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address all comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.h ('k') | third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

diff --git a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

index 2979dcbabdb74c80e0c7286a410af02a12fa8a23..4dd505090cdba5c8f2e4faa9a8c3ffb058615c59 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

+++ b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp

@@ -10,8 +10,13 @@

namespace blink {

-OffscreenCanvasRenderingContext2D* OffscreenCanvasModules::getContext(OffscreenCanvas& offscreenCanvas, const String& id, const CanvasContextCreationAttributes& attributes)

+OffscreenCanvasRenderingContext2D* OffscreenCanvasModules::getContext(OffscreenCanvas& offscreenCanvas, const String& id, const CanvasContextCreationAttributes& attributes, ExceptionState& exceptionState)

{

+ if (offscreenCanvas.isNeutered()) {

+ exceptionState.throwDOMException(InvalidStateError, "OffscreenCanvas object is detached");

+ return nullptr;

+ }

CanvasRenderingContext* context = offscreenCanvas.getCanvasRenderingContext(id, attributes);

if (!context)

return nullptr;