third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp - Issue 1917733004: Reland of: Make OffscreenCanvas Transferable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp

Issue 1917733004: Reland of: Make OffscreenCanvas Transferable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address all comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/Transferables.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp

index a3fd0a5591e92f7d5f8cea3fe12ef782c9e1367a..d3324ea9eb73eea4a274adec5882e2bf50350560 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp

@@ -114,6 +114,9 @@ void SerializedScriptValueFactory::transferData(SerializedScriptValue* serialize

if (exceptionState.hadException())

return;

serializedValue->transferArrayBuffers(isolate, transferables->arrayBuffers, exceptionState);

+ if (exceptionState.hadException())

+ return;

+ serializedValue->transferOffscreenCanvas(isolate, transferables->offscreenCanvases, exceptionState);

}

ScriptValueSerializer::Status SerializedScriptValueFactory::doSerialize(v8::Local<v8::Value> value, SerializedScriptValueWriter& writer, Transferables* transferables, WebBlobInfoArray* blobInfo, SerializedScriptValue* serializedValue, v8::TryCatch& tryCatch, String& errorMessage, v8::Isolate* isolate)