[DevTools] Move part of CommandLineAPI to native

third_party/WebKit/Source/platform/v8_inspector/V8Console.h

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
index 5f6e5e5da1e76f5b0ece06447221999f491894e1..8dcbcac50135053ecb37dd5cf244acedd7395013 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
@@ -15,9 +15,11 @@ class InspectedContext;
 // https://console.spec.whatwg.org/#console-interface
 class V8Console {
 public:
-    static v8::MaybeLocal<v8::Object> create(v8::Local<v8::Context>, InspectedContext*, bool hasMemoryAttribute);
+    static v8::MaybeLocal<v8::Object> createConsole(v8::Local<v8::Context>, InspectedContext*, bool hasMemoryAttribute);
+    static v8::Local<v8::Object> createCommandLineAPI(v8::Local<v8::Context>, InspectedContext*);

[dgozman, 2016/04/25 18:09:50]

Can we create it only once lazily and reuse?

[kozy, 2016/04/25 19:31:06]

Done.

     static void clearInspectedContextIfNeeded(v8::Local<v8::Context>, v8::Local<v8::Object> console);
 
+private:
     static void debugCallback(const v8::FunctionCallbackInfo<v8::Value>&);
     static void errorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
     static void infoCallback(const v8::FunctionCallbackInfo<v8::Value>&);
@@ -45,6 +47,14 @@ public:
     // https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5YRCGpC9vs/b4OJz71NmPwJ
     static void memoryGetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);
     static void memorySetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+
+    // CommandLineAPI
+    static void keysCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+    static void valuesCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+    static void debugFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+    static void undebugFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+    static void monitorFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+    static void unmonitorFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
 };
 
 } // namespace blink