Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.h

Issue 1917733002: [DevTools] Move part of CommandLineAPI to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
index 5f6e5e5da1e76f5b0ece06447221999f491894e1..5b0125191e1dd65a0b99d0e858378cbba02e42fd 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.h
@@ -15,9 +15,11 @@ class InspectedContext;
// https://console.spec.whatwg.org/#console-interface
class V8Console {
public:
- static v8::MaybeLocal<v8::Object> create(v8::Local<v8::Context>, InspectedContext*, bool hasMemoryAttribute);
+ static v8::MaybeLocal<v8::Object> createConsole(InspectedContext*, bool hasMemoryAttribute);
+ static v8::Local<v8::Object> createCommandLineAPI(InspectedContext*);
static void clearInspectedContextIfNeeded(v8::Local<v8::Context>, v8::Local<v8::Object> console);
+private:
static void debugCallback(const v8::FunctionCallbackInfo<v8::Value>&);
static void errorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
static void infoCallback(const v8::FunctionCallbackInfo<v8::Value>&);
@@ -45,6 +47,15 @@ public:
// https://groups.google.com/a/chromium.org/d/msg/blink-dev/g5YRCGpC9vs/b4OJz71NmPwJ
static void memoryGetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);
static void memorySetterCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+
+ // CommandLineAPI
+ static void keysCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void valuesCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void debugFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void undebugFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void monitorFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void unmonitorFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void lastEvaluationResultCallback(const v8::FunctionCallbackInfo<v8::Value>&);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698