Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 1917733002: [DevTools] Move part of CommandLineAPI to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
index 84350fd79f8bae64f2d94cbdf2d988841a6fbfd5..bad8de840e335591a608eb628f1095bba9f4231a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h
@@ -86,6 +86,7 @@ public:
OwnPtr<protocol::Runtime::RemoteObject>* result,
Maybe<bool>* wasThrown,
Maybe<protocol::Runtime::ExceptionDetails>*);
+ v8::Local<v8::Value> lastEvaluationResult() const;
class Scope {
public:
@@ -110,12 +111,12 @@ public:
private:
void cleanup();
V8DebuggerImpl::PauseOnExceptionsState setPauseOnExceptionsState(V8DebuggerImpl::PauseOnExceptionsState);
- v8::MaybeLocal<v8::Object> installGlobalObjectExtension(V8FunctionCall&);
+ bool installGlobalObjectExtension(v8::Local<v8::Object>);
v8::HandleScope m_handleScope;
v8::TryCatch m_tryCatch;
v8::Local<v8::Context> m_context;
- v8::Local<v8::Symbol> m_extensionSymbol;
+ v8::Local<v8::Private> m_extensionPrivate;
v8::MaybeLocal<v8::Object> m_global;
bool m_ignoreExceptionsAndMuteConsole;
V8DebuggerImpl::PauseOnExceptionsState m_previousPauseOnExceptionsState;
@@ -160,14 +161,15 @@ public:
private:
InjectedScript(InspectedContext*, v8::Local<v8::Object>, PassOwnPtr<InjectedScriptNative>);
bool canAccessInspectedWindow() const;
- v8::Local<v8::Value> lastEvaluationResult() const;
v8::Local<v8::Value> v8Value() const;
v8::MaybeLocal<v8::Value> wrapValue(ErrorString*, v8::Local<v8::Value>, const String16& groupName, bool forceValueType, bool generatePreview) const;
+ v8::MaybeLocal<v8::Object> commandLineAPI(ErrorString*);
InspectedContext* m_context;
v8::Global<v8::Value> m_value;
v8::Global<v8::Value> m_lastEvaluationResult;
OwnPtr<InjectedScriptNative> m_native;
+ v8::Global<v8::Object> m_commandLineAPI;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698