Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1917713003:
[Smart Lock] Fix "turn off" button in auto-signin first run experience. (Closed)
|
Created:
4 years, 8 months ago by melandory Modified:
4 years, 7 months ago Reviewers:
vabr (Chromium) CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Smart Lock] Fix "turn off" button in auto-signin first run experience.
BUG=606206
Committed: https://crrev.com/da55ab76c24c3da0179daddc424443a1328e9abd
Cr-Commit-Position: refs/heads/master@{#389457}
Patch Set 1 : #Patch Set 2 : #
Messages
Total messages: 26 (15 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917713003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917713003/80001
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917713003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917713003/100001
melandory@chromium.org changed reviewers: + vabr@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917713003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917713003/120001
The CQ bit was checked by melandory@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917713003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917713003/140001
Patchset #2 (id:80001) has been deleted
Patchset #2 (id:100001) has been deleted
Patchset #2 (id:120001) has been deleted
LGTM!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by melandory@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917713003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917713003/140001
Message was sent while issue was closed.
Committed patchset #2 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== [Smart Lock] Fix "turn off" button in auto-signin first run experience. BUG=606206 ========== to ========== [Smart Lock] Fix "turn off" button in auto-signin first run experience. BUG=606206 Committed: https://crrev.com/da55ab76c24c3da0179daddc424443a1328e9abd Cr-Commit-Position: refs/heads/master@{#389457} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/da55ab76c24c3da0179daddc424443a1328e9abd Cr-Commit-Position: refs/heads/master@{#389457} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
