components/wifi_sync/network_state_helper_chromeos.cc - Issue 1917673002: Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/wifi_sync/network_state_helper_chromeos.cc

Issue 1917673002: Convert //components/[u-z]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Build fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/wifi/fake_wifi_service.cc ('K') | « components/wifi/wifi_test.cc ('k') | components/wifi_sync/wifi_config_delegate_chromeos.cc » ('j') | components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/wifi_sync/network_state_helper_chromeos.cc

diff --git a/components/wifi_sync/network_state_helper_chromeos.cc b/components/wifi_sync/network_state_helper_chromeos.cc

index f7afa73d4c22d512e29b48285c2f76c9c2ecdadb..3383f07fd5fa9373be07691599f0dc76750290c4 100644

--- a/components/wifi_sync/network_state_helper_chromeos.cc

+++ b/components/wifi_sync/network_state_helper_chromeos.cc

@@ -33,11 +33,10 @@ WifiCredential::CredentialSet GetWifiCredentialsForShillProfile(

// TODO(quiche): Fill in the actual passphrase via an asynchronous

// call to a chromeos::NetworkConfigurationHandler instance's

// GetProperties method.

- scoped_ptr<WifiCredential> credential =

- WifiCredential::Create(

- network->raw_ssid(),

- WifiSecurityClassFromShillSecurity(network->security_class()),

- "" /* empty passphrase */);

+ std::unique_ptr<WifiCredential> credential = WifiCredential::Create(

danakj 2016/04/25 18:32:58 include memory

dcheng 2016/04/25 19:55:06 Done.

+ network->raw_ssid(),

+ WifiSecurityClassFromShillSecurity(network->security_class()),

+ "" /* empty passphrase */);

if (!credential)

LOG(ERROR) << "Failed to create credential";

else