components/wifi/fake_wifi_service.h - Issue 1917673002: Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/wifi/fake_wifi_service.h

Issue 1917673002: Convert //components/[u-z]* from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Build fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/variations/service/variations_service_unittest.cc ('K') | « components/webusb/webusb_detector.cc ('k') | components/wifi/fake_wifi_service.cc » ('j') | components/wifi/fake_wifi_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/wifi/fake_wifi_service.h

diff --git a/components/wifi/fake_wifi_service.h b/components/wifi/fake_wifi_service.h

index bb5c757479571981eb200b574be00ec2043b8dbb..551a8b4787879513abe9848916eae76dbd6ec6ec 100644

--- a/components/wifi/fake_wifi_service.h

+++ b/components/wifi/fake_wifi_service.h

@@ -34,10 +34,10 @@ class FakeWiFiService : public WiFiService {

base::DictionaryValue* properties,

std::string* error) override;

void SetProperties(const std::string& network_guid,

- scoped_ptr<base::DictionaryValue> properties,

+ std::unique_ptr<base::DictionaryValue> properties,

danakj 2016/04/25 18:32:58 include memory

dcheng 2016/04/25 19:55:06 Same comment about this being mentioned only in an

std::string* error) override;

void CreateNetwork(bool shared,

- scoped_ptr<base::DictionaryValue> properties,

+ std::unique_ptr<base::DictionaryValue> properties,

std::string* network_guid,

std::string* error) override;

void GetVisibleNetworks(const std::string& network_type,