Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org

Committed: https://crrev.com/3f767dc3724b2e3f36c17ee760007475de7e63cc
Cr-Commit-Position: refs/heads/master@{#389596}

[dcheng, 2016-04-25 18:04:18]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org, jochen@chromium.org

[dcheng, 2016-04-25 18:04:19]

+danakj@ for sanity review
+jochen@ for owners stamp (will TBR)

[danakj, 2016-04-25 18:32:59]

LGTM

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
File components/undo/bookmark_undo_service.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
components/undo/bookmark_undo_service.cc:10: #include <memory>
dont need then

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
File components/undo/bookmark_undo_service.h (right):

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
components/undo/bookmark_undo_service.h:72:
std::unique_ptr<bookmarks::BookmarkNode> node) override;
include memory

https://codereview.chromium.org/1917673002/diff/40001/components/user_prefs/t...
File components/user_prefs/tracked/interceptable_pref_filter.h (right):

https://codereview.chromium.org/1917673002/diff/40001/components/user_prefs/t...
components/user_prefs/tracked/interceptable_pref_filter.h:8: #include <memory>
unused

https://codereview.chromium.org/1917673002/diff/40001/components/variations/s...
File components/variations/service/variations_service_unittest.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/variations/s...
components/variations/service/variations_service_unittest.cc:364:
std::unique_ptr<TestVariationsServiceClient> client =
include memory?

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
File components/wifi/fake_wifi_service.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
components/wifi/fake_wifi_service.cc:7: #include <memory>
not needed then

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
File components/wifi/fake_wifi_service.h (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
components/wifi/fake_wifi_service.h:37: std::unique_ptr<base::DictionaryValue>
properties,
include memory

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/ne...
File components/wifi_sync/network_state_helper_chromeos.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/ne...
components/wifi_sync/network_state_helper_chromeos.cc:36:
std::unique_ptr<WifiCredential> credential = WifiCredential::Create(
include memory

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/wi...
File components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/wi...
components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc:154:
std::unique_ptr<WifiCredential> credential = WifiCredential::Create(
include memory

[dcheng, 2016-04-25 19:55:07]

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
File components/undo/bookmark_undo_service.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
components/undo/bookmark_undo_service.cc:10: #include <memory>
On 2016/04/25 at 18:32:58, danakj wrote:
> dont need then

See previous.

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
File components/undo/bookmark_undo_service.h (right):

https://codereview.chromium.org/1917673002/diff/40001/components/undo/bookmar...
components/undo/bookmark_undo_service.h:72:
std::unique_ptr<bookmarks::BookmarkNode> node) override;
On 2016/04/25 at 18:32:58, danakj wrote:
> include memory

I structured it this way because it's only referenced in an override in the
header.

https://codereview.chromium.org/1917673002/diff/40001/components/user_prefs/t...
File components/user_prefs/tracked/interceptable_pref_filter.h (right):

https://codereview.chromium.org/1917673002/diff/40001/components/user_prefs/t...
components/user_prefs/tracked/interceptable_pref_filter.h:8: #include <memory>
On 2016/04/25 at 18:32:58, danakj wrote:
> unused

This is needed: this is an include that was added to fix IWYU issues while
landing other patches.

https://codereview.chromium.org/1917673002/diff/40001/components/variations/s...
File components/variations/service/variations_service_unittest.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/variations/s...
components/variations/service/variations_service_unittest.cc:364:
std::unique_ptr<TestVariationsServiceClient> client =
On 2016/04/25 at 18:32:58, danakj wrote:
> include memory?

Done.

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
File components/wifi/fake_wifi_service.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
components/wifi/fake_wifi_service.cc:7: #include <memory>
On 2016/04/25 at 18:32:58, danakj wrote:
> not needed then

See previous.

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
File components/wifi/fake_wifi_service.h (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi/fake_wi...
components/wifi/fake_wifi_service.h:37: std::unique_ptr<base::DictionaryValue>
properties,
On 2016/04/25 at 18:32:58, danakj wrote:
> include memory

Same comment about this being mentioned only in an override in the header.

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/ne...
File components/wifi_sync/network_state_helper_chromeos.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/ne...
components/wifi_sync/network_state_helper_chromeos.cc:36:
std::unique_ptr<WifiCredential> credential = WifiCredential::Create(
On 2016/04/25 at 18:32:58, danakj wrote:
> include memory

Done.

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/wi...
File components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc (right):

https://codereview.chromium.org/1917673002/diff/40001/components/wifi_sync/wi...
components/wifi_sync/wifi_config_delegate_chromeos_unittest.cc:154:
std::unique_ptr<WifiCredential> credential = WifiCredential::Create(
On 2016/04/25 at 18:32:58, danakj wrote:
> include memory

DOne.

[danakj, 2016-04-25 19:56:29]

ok sgtm

[dcheng, 2016-04-25 22:40:14]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-25 22:40:15]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1917673002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-04-25 22:40:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917673002/60001

[dcheng, 2016-04-25 22:43:39]

Description was changed from

==========
Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-04-25 22:54:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-25 22:56:37]

Description was changed from

==========
Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org
==========

to

==========
Convert //components/[u-z]* from scoped_ptr to std::unique_ptr

BUG=554298
R=danakj@chromium.org
TBR=jochen@chromium.org

Committed: https://crrev.com/3f767dc3724b2e3f36c17ee760007475de7e63cc
Cr-Commit-Position: refs/heads/master@{#389596}
==========

[commit-bot: I haz the power, 2016-04-25 22:56:38]

Patchset 4 (id:??) landed as
https://crrev.com/3f767dc3724b2e3f36c17ee760007475de7e63cc
Cr-Commit-Position: refs/heads/master@{#389596}