chrome/browser/BUILD.gn - Issue 1917653002: Re-Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 1917653002: Re-Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a wrapper to change python args, for GYP and GN Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index d1822163215dfcd57d6b5d51d337ae7810d6675d..c873b6a70d5bab31ce4cbbdf0b9b6fb13036ae26 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -1032,6 +1032,7 @@ grit("resources") {

deps = [

":chrome_internal_resources_gen",

+ "//chrome/browser/resources/safe_browsing:make_file_types_protobuf",

# Depend only on the generated mojo bindings since we read the .mojom.js

# file, rather than the whole mojo target which will link the C++ bindings.

« no previous file with comments | « no previous file | chrome/browser/browser_resources.grd » ('j') | chrome/browser/resources/safe_browsing/gen_file_type_proto.py » ('J')