Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1917653002: Re-Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource. (Closed)

Created:
4 years, 8 months ago by Nathan Parker
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, xyzzyz
CC:
chromium-reviews, grt+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource. This reverts commit 90ade35dd2736cc1fa3eb9fc67e83640345b519b Adds: -S -s args to /usr/bin/python BUG=596555 Committed: https://crrev.com/38c5a5c84d4dd41134fb16ff5209ff8464de60cc Cr-Commit-Position: refs/heads/master@{#389612}

Patch Set 1 #

Patch Set 2 : Add -S to python interpreter to disable site-packages in GYP #

Patch Set 3 : Add a wrapper to change python args, for GYP and GN #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -3 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/safe_browsing/BUILD.gn View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/resources/safe_browsing/README.md View 1 chunk +96 lines, -0 lines 0 comments Download
A chrome/browser/resources/safe_browsing/download_file_types.asciipb View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/browser/resources/safe_browsing/gen_file_type_proto.py View 1 2 1 chunk +79 lines, -0 lines 1 comment Download
M chrome/chrome_common.gypi View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 2 2 chunks +42 lines, -0 lines 0 comments Download
M chrome/common/safe_browsing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/safe_browsing/download_file_types.proto View 1 chunk +65 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
Nathan Parker
4 years, 8 months ago (2016-04-25 22:12:24 UTC) #5
xyzzyz
LGTM I checked it in ChromeOS chroot, and it seems to be working now. https://codereview.chromium.org/1917653002/diff/80001/chrome/browser/resources/safe_browsing/gen_file_type_proto.py ...
4 years, 8 months ago (2016-04-25 23:02:21 UTC) #6
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-25 23:05:08 UTC) #7
Nathan Parker
Woo hoo!
4 years, 8 months ago (2016-04-25 23:25:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917653002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917653002/80001
4 years, 8 months ago (2016-04-25 23:26:18 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 8 months ago (2016-04-25 23:34:39 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:36:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/38c5a5c84d4dd41134fb16ff5209ff8464de60cc
Cr-Commit-Position: refs/heads/master@{#389612}

Powered by Google App Engine
This is Rietveld 408576698