Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/mesa/BUILD.gn

Issue 1917603002: third_party/mesa: turn off ubsan_vptr, since it's compiled without rtti. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/mesa/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mesa/BUILD.gn
diff --git a/third_party/mesa/BUILD.gn b/third_party/mesa/BUILD.gn
index 427d4b62c42471cb9a820ef717f77e2c886034bd..5996ee0a0197b0cb6e1d6b31e6dd0e0c653ea07d 100644
--- a/third_party/mesa/BUILD.gn
+++ b/third_party/mesa/BUILD.gn
@@ -127,6 +127,11 @@ config("mesa_internal_warnings") {
"-Wno-unused-local-typedef",
]
}
+ if (is_ubsan_vptr) {
+ # UBsan's vptr is not compatible with -fno-rtti,
+ # which is used by gallium/auxiliary/Makefile.
+ cflags += [ "-fno-sanitize=vptr" ]
Dirk Pranke 2016/04/22 23:04:56 This is dangerous, because this is likely sensitiv
+ }
if (is_win) {
# TODO(scottmg): http://crbug.com/143877 These should be removed if
# Mesa is ever rolled and the warnings are fixed.
« no previous file with comments | « no previous file | third_party/mesa/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698