Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Issue 1917543002: DevTools: Update styles for sensors drawer panel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: UI update for sensors panel Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
index 9b462083694f1c3a7b0797f5c505f7162305af29..c642128cf74123e35389591be08c3a77903746a0 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
@@ -1519,7 +1519,8 @@ WebInspector.bindInput = function(input, apply, validate, numeric)
var valid = validate(value);
input.classList.toggle("error-input", !valid);
input.value = value;
- input.setSelectionRange(value.length, value.length);
+ if (input.type !== "number")
lushnikov 2016/04/23 00:19:46 why do we avoid this for number inputs?
luoe 2016/04/25 19:26:41 According to the spec, number inputs are not suppo
lushnikov 2016/04/25 23:33:04 Yeah, tricky! I would leave a comment here, thanks
luoe 2016/04/26 02:16:22 Done.
+ input.setSelectionRange(value.length, value.length);
}
return setValue;

Powered by Google App Engine
This is Rietveld 408576698