DevTools: Update styles for sensors drawer panel

third_party/WebKit/Source/devtools/front_end/emulation/Geolocation.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {number} latitude
  * @param {number} longitude
  * @param {string} error
  */
 WebInspector.Geolocation = function(latitude, longitude, error)
 {
     this.latitude = latitude;
     this.longitude = longitude;
     this.error = error;
 }
 
 WebInspector.Geolocation.prototype = {
     /**
      * @return {string}
      */
     toSetting: function()
     {
         return (typeof this.latitude === "number" && typeof this.longitude === "number" && typeof this.error === "string") ? this.latitude + "@" + this.longitude + ":" + this.error : "";
     },
 
     apply: function()
     {
         for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page)) {
-            if (this.error)
+            if (this.error === WebInspector.Geolocation.Error.None)
+                target.emulationAgent().setGeolocationOverride(this.latitude, this.longitude, WebInspector.Geolocation.DefaultMockAccuracy);
+            else
                 target.emulationAgent().setGeolocationOverride();
-            else
-                target.emulationAgent().setGeolocationOverride(this.latitude, this.longitude, 150);
-
         }
     },
 
     clear: function()
     {
         for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page))
             target.emulationAgent().clearGeolocationOverride();
     }
 }
 
 /**
  * @return {!WebInspector.Geolocation}
  */
 WebInspector.Geolocation.parseSetting = function(value)

[lushnikov, 2016/04/25 23:33:04]

lets add jsdoc while we're here

[luoe, 2016/04/26 02:16:23]

Done.

 {
     if (value) {
         var splitError = value.split(":");
         if (splitError.length === 2) {
             var splitPosition = splitError[0].split("@");
             if (splitPosition.length === 2)
                 return new WebInspector.Geolocation(parseFloat(splitPosition[0]), parseFloat(splitPosition[1]), splitError[1]);
         }
     }
-    return new WebInspector.Geolocation(0, 0, "");
+    return new WebInspector.Geolocation(0, 0, WebInspector.Geolocation.Error.None);
 }
 
 /**
  * @return {?WebInspector.Geolocation}
  */
 WebInspector.Geolocation.parseUserInput = function(latitudeString, longitudeString, errorStatus)

[lushnikov, 2016/04/25 23:33:04]

lets add jsdoc while we are here

[luoe, 2016/04/26 02:16:23]

Done.

 {
     if (!latitudeString && !longitudeString)
         return null;
 
     var isLatitudeValid = WebInspector.Geolocation.latitudeValidator(latitudeString);
     var isLongitudeValid = WebInspector.Geolocation.longitudeValidator(longitudeString);
 
     if (!isLatitudeValid && !isLongitudeValid)
         return null;
 
     var latitude = isLatitudeValid ? parseFloat(latitudeString) : -1;
     var longitude = isLongitudeValid ? parseFloat(longitudeString) : -1;
-
-    return new WebInspector.Geolocation(latitude, longitude, errorStatus ? "PositionUnavailable" : "");
+    var error = errorStatus ? WebInspector.Geolocation.Error.PositionUnavailable : WebInspector.Geolocation.Error.None;
+    return new WebInspector.Geolocation(latitude, longitude, error);
 }
 
 /**
  * @param {string} value
  * @return {boolean}
  */
 WebInspector.Geolocation.latitudeValidator = function(value)
 {
     return !value || (/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -90 && value <= 90);
 }
 
 /**
  * @param {string} value
  * @return {boolean}
  */
 WebInspector.Geolocation.longitudeValidator = function(value)
 {
     return !value || (/^([+-]?[\d]+(\.\d+)?|[+-]?\.\d+)$/.test(value) && value >= -180 && value <= 180);
 }
+
+/** @enum {string} */
+WebInspector.Geolocation.Error = {

[lushnikov, 2016/04/25 23:33:04]

i think having the enum is a bit of overkill here. You are never interested in
the value of the error in the
geolocation object - only in its existance.

Looks like bool should be enough

[luoe, 2016/04/26 02:16:23]

Done.

+    None: "None",
+    PositionUnavailable: "PositionUnavailable"
+}
+
+WebInspector.Geolocation.DefaultMockAccuracy = 150;