Use std::map in xfa_ffdoc.cpp

Use std::map in xfa_ffdoc.cpp

Committed: https://pdfium.googlesource.com/pdfium/+/084174a3523e0ebdbf2d9d1c9902d2ba4875182e

[Tom Sepez, 2016-04-22 18:39:39]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-04-22 18:39:39]

Lei, please review.

[Tom Sepez, 2016-04-22 19:16:41]

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp#...
xfa/fxfa/app/xfa_ffdoc.cpp:304: CFX_DIBitmap* CXFA_FFDoc::GetPDFNamedImage(const
CFX_WideStringC& wsName,
Should this just return a DIBDPI struct?

[Tom Sepez, 2016-04-22 21:51:40]

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp#...
xfa/fxfa/app/xfa_ffdoc.cpp:304: CFX_DIBitmap* CXFA_FFDoc::GetPDFNamedImage(const
CFX_WideStringC& wsName,
On 2016/04/22 19:16:41, Tom Sepez wrote:
> Should this just return a DIBDPI struct?

Ah, lets just leave it for the moment.

[Lei Zhang, 2016-04-22 23:37:50]

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp#...
xfa/fxfa/app/xfa_ffdoc.cpp:345: if (!pObject || !pObject->IsStream())
CPDF_Stream* pStream = ToStream(pObject);
if (!pStream)
  return nullptr.

Use pStream on line 349.

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/include/xfa_ffdoc.h
File xfa/fxfa/include/xfa_ffdoc.h (right):

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/include/xfa_ffdoc....
xfa/fxfa/include/xfa_ffdoc.h:62: std::map<uint32_t, CXFA_FFDocView*>
m_TypeToDocViewMap;
Should the value in the map be a std::unique_ptr?

[Tom Sepez, 2016-04-25 18:23:06]

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1917493002/diff/1/xfa/fxfa/app/xfa_ffdoc.cpp#...
xfa/fxfa/app/xfa_ffdoc.cpp:345: if (!pObject || !pObject->IsStream())
On 2016/04/22 23:37:50, Lei Zhang wrote:
> CPDF_Stream* pStream = ToStream(pObject);
> if (!pStream)
>   return nullptr.
> 
> Use pStream on line 349.

Done.

[Lei Zhang, 2016-04-25 18:26:09]

lgtm

[Tom Sepez, 2016-04-25 18:55:38]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-04-25 18:55:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917493002/20001

[commit-bot: I haz the power, 2016-04-25 18:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 18:57:19]

Try jobs failed on following builders:
  win_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_no_v8/build...)

[Tom Sepez, 2016-04-25 19:25:30]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-04-25 19:25:31]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1917493002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-25 19:25:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917493002/40001

[commit-bot: I haz the power, 2016-04-25 19:37:30]

Description was changed from

==========
Use std::map in xfa_ffdoc.cpp
==========

to

==========
Use std::map in xfa_ffdoc.cpp

Committed:
https://pdfium.googlesource.com/pdfium/+/084174a3523e0ebdbf2d9d1c9902d2ba4875...
==========

[commit-bot: I haz the power, 2016-04-25 19:37:31]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/084174a3523e0ebdbf2d9d1c9902d2ba4875...