git_cl.py - Issue 1917473002: Make `git cl description` work for Gerrit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1917473002: Make `git cl description` work for Gerrit (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index d8fd642246aaff5e6f64f02b96b497517d4f74aa..7cad3bf8a7c10af7aef94c3d4aaa12dcf7fc8127 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -2167,8 +2167,8 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):

return data['revisions'][data['current_revision']]['commit_with_footers']

def UpdateDescriptionRemote(self, description):

- # TODO(tandrii)

- raise NotImplementedError()

+ gerrit_util.SetCommitMessage(self._GetGerritHost(), self.GetIssue(),

+ description)

def CloseIssue(self):

gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')

« gerrit_util.py ('K') | « gerrit_util.py ('k') | no next file » | no next file with comments »